Rhoban / onshape-to-robot

Converting OnShape assembly to robot definition (SDF or URDF) through OnShape API
MIT License
237 stars 55 forks source link

Use url encoding on part id #106

Open mfaizudd opened 1 year ago

mfaizudd commented 1 year ago

Recently, I've been trying to create an SDF file from an Onshape document, but it fails and tells me that some URL returns a 404 error. It turns out that this happens because the part ID contains a plus (+) character. I also came across issue #46 which fixes the unescaped slash problem. However, part IDs can also contain plus signs and possibly other characters. Therefore, I believe it would be best to URL encode the entire part ID. I also changed the function name since it no longer just escapes the slash.