Closed csamid closed 1 year ago
Hello,
Seems good to me, only we know to update requirements.txt
and setup.py
to depend on colorama >= 0.4.6
which includes just_fix_window_console
. I will merge, do it and repackage
Updated dependency and uploaded upstream v0.3.20
Can you confirm me it's working ?
It works!
What
This pull request: 1) enables OpenSCAD detection on Windows 2) resolves a color output inconsistency issue on Windows consoles.
Why
1) OpenSCAD detection was not available on Windows systems. 2) OpenSCAD detection changes introduced a color output inconsistencies on Windows consoles.
How
OpenSCAD Detection
I replaced
os.system()
withsubprocess.run()
for executingopenscad -v
Colorama Solution
Calls
just_fix_windows_console()
function from thecolorama
library to address the color output inconsistency.Visual Demos
Screenshots below illustrate the impact of the changes. These showcase code output comparisons before and after the modifications. It covers both Windows and Linux environments while OpenSCAD is installed
Before and After Screenshots