search

Rhoban / onshape-to-robot

Converting OnShape assembly to robot definition (SDF or URDF) through OnShape API
MIT License
237 stars 55 forks source link

Update setup.py to use entry_points #60

Closed rsinnet closed 2 years ago

rsinnet commented 2 years ago

Use the entry_points options to auto-generate CLI entrypoint scripts. These scripts are generated by the installer so they take into account the system's environment and thus are more robust.

Gregwar commented 2 years ago

Hello,

Thanks for your suggestion If we go this way I think we should also make clear-cache uniform with the rest, would you mind updating PR ?

rsinnet commented 2 years ago

Hello,

Thanks for your suggestion If we go this way I think we should also make clear-cache uniform with the rest, would you mind updating PR ?

Good call. I updated the clear-cache script and added a few more commits to clean things up. See the commit messages for more details.

I also added a final commit where I remove the previous scripts. You can drop that if you want. However, I left a comment in the commit message about how to run the scripts using python3 -m onshape_to_robot.onshape_to_robot when developing on the package so it could be a nice clean up.

rsinnet commented 2 years ago

@Gregwar addressed your comments FYI.

Gregwar commented 2 years ago

Sounds good, thanks for contributing

Gregwar commented 2 years ago

I will publish a new version anytime soon