search

Rhoban / onshape-to-robot

Converting OnShape assembly to robot definition (SDF or URDF) through OnShape API
MIT License
231 stars 49 forks source link

Joint limits searched for in wrong assembly #77

Open rsinnet opened 2 years ago

rsinnet commented 2 years ago

During initial feature loading, a request is made to the Onshape API, but this request can be on the wrong assembly. It seems the request is made on what becomes the root assembly, but that can be the first assembly in the assembly tab. The actual root assembly has the same name as the tab.

I fixed this in our fork, but reporting it here FYI.

Gregwar commented 2 years ago

Hello Ryan,

Thanks for your PRs! I will likely not be able to review them anytime soon since I am currently preparing for RoboCup 2022 that will be held next week

Do not hesitate to ping be again mid-july!