search

RiecoinTeam / Riecoin

Riecoin Core repository. Riecoin Whitepaper: https://riecoin.xyz/Whitepaper
https://riecoin.xyz/Core/
MIT License
10 stars 6 forks source link

Tests fail #9

Open cryptapus opened 5 years ago

cryptapus commented 5 years ago

Currently tests fail for Riecoin. It is a long term goal to have them functional.

Pttn commented 4 years ago

I rewrote most tests for Riecoin, but there is still a few things to do.

Some cases should to be recreated in src/test/data/blockfilters.json CreateNewBlock_validity needs to be rewritten, it is not that trivial as the Fair Launch needs to be taken in account, and rieMiner needs to be adapted in order to find suitable 6-tuples (due to the Offset < 2^39 restriction; rieMiner does not support Extra Nonces).

Some Fuzz Tests fail due to Gmp in Travis, no idea why (see the Travis Logs for 00_setup_env_native_fuzz.sh).

p2p_dos_header_tree.py probably just needs new data. I don't know why feature_assumevalid.py is failing. As well as the Linearize tools and consequently feature_loadblock.py. Some tests still need to be adapted to take in account the 2x Block Size and 4x Max SigOps: in feature_block.py, b40 and b41 tests will produce too big blocks and cause unwanted bad-blk-length errors, and need to be rewritten to properly test the bad-blk-sigops error. In test_witness_block_size.py, test_witness_block_size and test_witness_sigops probably just need a few count changes, but I can't seem to find out which ones...

Help needed to fix the remaining problems.