search

RileCraft / DiscordBot-Template

A bot template with command , event , button , selectmenus , slashcommands handler and error handlers. Made in Discord.JS V14
MIT License
229 stars 59 forks source link

MySQL Implementation #88

Closed GoldO-dev closed 6 months ago

GoldO-dev commented 6 months ago

This pull request adds MySQL compatability to the bot. This is done using a npm package called mysql

Link to the commit with the code: https://github.com/RileCraft/DiscordBot-Template/pull/88/commits/ac9e705c0271c7bbf6e5294760e9b94fcce43646

RileCraft commented 6 months ago

I do not see the point of implementing an external database in the template. If the user wishes to implement a database then they are free to manually do so as they please.

GoldO-dev commented 6 months ago

Okay, the reason I've made a implementation like this, is because I personally have been asked over 20 times to implement a mysql database into this template.

I also personally think that it being implemented by default would make it easier for the user to make what they want using this template more easily.

Would you consider maybe adding it as a separate branch? So people can choose if they want to use it with a MySQL implementation.

GoldO-dev commented 6 months ago

I've made it so it's easy for the user. If they want to use it with a MySQL database they put in the information into the config, and change USE_DB to true.

If they don't want to use it with a MySQL database they just don't change the information in the config file.

RileCraft commented 6 months ago

I am not knowledgeable about MySQL and i already struggle with maintaining as this is currently and also if i make branch for MySQL then more people will ask for other databases or features which will create it's own mess.

GoldO-dev commented 6 months ago

Okay it makes sense.