[BUG] Reduce redownloading of unchanged files

Rinnegatamante / DaedalusX64-vitaGL

Daedalus X64 port for PSVITA through vitaGL.

GNU General Public License v2.0

392 stars 47 forks source link

[BUG] Reduce redownloading of unchanged files #59

Open Sarkie opened 4 years ago

Sarkie commented 4 years ago

Describe the bug Currently the same files are being downloading from gitub

To Reproduce Start the software Files will be downloaded

Expected behavior Github api uses ETag, so you can use If-Match header on the GET request to reduce downloading

Screenshots

Device:

Device: [e.g. PSP Model or VITA]
FW:[e.g. Current System Firmware]
Daedalus Version 0.2 Nightly

Additional context Add any other context about the problem here.

Sarkie commented 4 years ago

@Rinnegatamante also noticed the comment regarding Content-Length missing, I think there's a bug or something with Github api - I've created a forum post.

https://github.community/t5/GitHub-API-Development-and/Content-Length-missing-randomly/m-p/57784#M4856

Rinnegatamante commented 4 years ago

It's not a bug, GitHub API uses chunked transmission. Chunked transmission misses Content-Length.

e-minguez commented 4 years ago

What about generating MD5 files? So you can check the checksum and download only a few bytes.