search

Rinnegatamante / vitaQuake

Port of Quake for Playstation Vita
GNU General Public License v3.0
126 stars 20 forks source link

Underwater gfx not displayed correctly. #32

Closed ShroomKing closed 6 years ago

ShroomKing commented 6 years ago

Sorry, accidentally pressed enter and opened an issue without adding a description, i'll explain what i mean in a couple minutes + will add a couple screenshots

ShroomKing commented 6 years ago

So basically, when underwater everything get's pitch black and it's not really possible to see a thing aside from the water surface. first 2 screenshots are how it's supposed to look like and how it looked like on Software renderer vitaQuake

2018-01-16-152149

2018-01-16-152156

and the following screenshots are how it currently looks like on vita-glQuake

2018-01-16-151628

2018-01-16-154104

2018-01-16-153845

2018-01-16-151632

Also it seems like some particles are missing(Blood particles for example)

Other than that thanks for your work on this, the progress is impressive, and it rarely ever drops below 60fps(at max cpu/gpu/bus speeds)

Rinnegatamante commented 6 years ago

Do you have a screenshot from original glQuake? glQuake is well known to be a lot darker if compared to winQuake, i wouldn't be surprised if this is a glQuake "feature".

ShroomKing commented 6 years ago

This is how glQuake looks on my pc when underwater:

unnamed40

obviously i can see the floor/walls etc.

on vita-glQuake there is no geometry AT ALL when underwater, everything is just black.

Rinnegatamante commented 6 years ago

Putting some reference here if someone wants to work on the issue:

The issue was not present before moving from vitaGL standard shaders to custom specialized shaders. With that being said, the issue came out from https://github.com/Rinnegatamante/vitaQuake/commit/24e883897482d280c5055255083df883c39261ac this commit or a later one, surely not from a previous one.

Rinnegatamante commented 6 years ago

Issue is related to lightmaps. Using r_fullbright to disable lightmaps actually fixes the issue.

Rinnegatamante commented 6 years ago

The function causing this bug is DrawGLWaterPolyLightmap in gl_rsurf.

Count-Duckula-AU commented 6 years ago

Underwater looks great now with vitaquake v2.6. Everything is visible and the warping effect is present :)

Rinnegatamante commented 6 years ago

v.2.6 introduced a temporary fix that disables lightmaps. Issue is still here if underwater lightmaps are enabled like they should be.

Count-Duckula-AU commented 6 years ago

Thanks for the clarification.

Rinnegatamante commented 6 years ago

Solved, was a bug in vitaGL.