RoadTripMoustache / kana_to_kanji

Simple application to learn Japanese kana (hiragana, katakana) and kanji
6 stars 1 forks source link

feat(#92): Implement bottom bar navigation #104

Closed apomalyn closed 11 months ago

apomalyn commented 11 months ago

📖 Description

This PR implements the bottom navigation bar with 5 tabs: home, learn, practice, glossary, and you. Currently, only practice and glossary are enabled.

I modified a little App to avoid rebuilding the router whenever we hot-reload the application.

⁉️ Related Issues

closes #92

🖼️ Screenshots:

Full application bar ![Screenshot 2023-11-10 at 5 16 38 PM](https://github.com/RoadTripMoustache/kana_to_kanji/assets/22211097/4a43b2c8-cf42-45ca-9c4f-50abc5937335)
Current application bar ![Screenshot 2023-11-10 at 5 19 44 PM](https://github.com/RoadTripMoustache/kana_to_kanji/assets/22211097/66f239fb-ac73-435b-8ceb-875bd7baefbd)

🧪 How to test the change?

  1. Open the application
  2. Tap on Glossary
  3. You should see a simple not found page

☑️ Checklist before requesting a review

github-actions[bot] commented 11 months ago

Bump version from 0.9.0+1 to 0.10.0+1

github-actions[bot] commented 11 months ago

Coverage after merging feat/92 into main will be

40.15%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/core/models
   app_navigation_destination.dart100%100%100%100%
lib/src/core/widgets
   app_bottom_navigation_bar.dart100%100%100%100%
   app_scaffold.dart0%100%100%0%18, 27–31, 33–34, 38–40
lib/src/quiz/prepare
   prepare_quiz_view.dart0%100%100%0%14, 16, 18, 20–22, 24–25, 28–31, 33–34, 38–48, 51, 53–56, 58–61, 65, 67–70, 80–83