Closed Adaendra closed 10 months ago
Bump version from 0.9.0+1 to 0.10.0+1
Je ne suis pas allé jusqu'à l'implémentation des services et repositories car je me dis que ça ferais du sens de les implémenter quand on va commencer à les utiliser. (histoire d'avoir les méthodes adaptées aux fonctionnalités, plutôt que de faire une v1 maintenant et le changer lors du développement des autres features)
Coverage after merging issue_94 into main will be
61.66% |
---|
File | Stmts | Branches | Funcs | Lines | Uncovered Lines |
---|---|---|---|---|---|
lib/src | |||||
locator.dart | 2.70% | 100% | 100% | 2.70% | 24–25, 28–33, 38–39, 42, 44–45, 54–60, 63–65, 67–70, 72–75, 77–80, 82 |
lib/src/core/dataloaders | |||||
kanji_dataloader.dart | 0% | 100% | 100% | 0% | 14–15, 19, 21–25, 29–34, 40 |
vocabulary_dataloader.dart | 0% | 100% | 100% | 0% | 14–15, 19, 21–25, 29–34, 40 |
lib/src/core/models | |||||
kanji.dart | 0% | 100% | 100% | 0% | 30, 42 |
vocabulary.dart | 0% | 100% | 100% | 0% | 24, 27–28 |
Bump version from 0.10.0+1 to 0.11.0+1
Bump version from 0.10.0+1 to 0.11.0+1
Coverage after merging issue_94 into main will be
38.75% |
---|
File | Stmts | Branches | Funcs | Lines | Uncovered Lines |
---|---|---|---|---|---|
lib/src | |||||
locator.dart | 2.70% | 100% | 100% | 2.70% | 24–25, 28–33, 38–39, 42, 44–45, 54–60, 63–65, 67–70, 72–75, 77–80, 82 |
lib/src/core/dataloaders | |||||
kanji_dataloader.dart | 0% | 100% | 100% | 0% | 14–15, 19, 21–25, 29–34, 40 |
vocabulary_dataloader.dart | 0% | 100% | 100% | 0% | 14–15, 19, 21–25, 29–34, 40 |
lib/src/core/models | |||||
kanji.dart | 0% | 100% | 100% | 0% | 40, 52 |
vocabulary.dart | 0% | 100% | 100% | 0% | 29, 32–33 |
Coverage after merging issue_94 into main will be
38.75% |
---|
File | Stmts | Branches | Funcs | Lines | Uncovered Lines |
---|---|---|---|---|---|
lib/src | |||||
locator.dart | 2.70% | 100% | 100% | 2.70% | 24–25, 28–33, 38–39, 42, 44–45, 54–60, 63–65, 67–70, 72–75, 77–80, 82 |
lib/src/core/dataloaders | |||||
kanji_dataloader.dart | 0% | 100% | 100% | 0% | 14–15, 19, 21–25, 29–34, 40 |
vocabulary_dataloader.dart | 0% | 100% | 100% | 0% | 14–15, 19, 21–25, 29–34, 40 |
lib/src/core/models | |||||
kanji.dart | 0% | 100% | 100% | 0% | 41, 53 |
vocabulary.dart | 0% | 100% | 100% | 0% | 29, 32–33 |
📖 Description
Update the application to load kanji et vocabulary at the opening of the application.
⁉️ Related Issues
closes https://github.com/RoadTripMoustache/kana_to_kanji/issues/94
🧪 How to test the change?
Currently, there's only one way to test it and it only check if the API call is done. Start the API locally, configure Kana to kanji to use the local API, then start the app. You should see the calls in the API logs.
☑️ Checklist before requesting a review
version: Major
,version: Minor
orversion: Patch
.