Closed Adaendra closed 8 months ago
Bump version from 0.11.0+1 to 0.12.0+1
Coverage after merging issue_93 into main will be
37.99% |
---|
File | Stmts | Branches | Funcs | Lines | Uncovered Lines |
---|---|---|---|---|---|
lib/src | |||||
locator.dart | 2.33% | 100% | 100% | 2.33% | 26–27, 30–35, 40–41, 44, 46–47, 56–68, 71–73, 75–78, 80–83, 85–88, 90 |
lib/src/core/repositories | |||||
kana_repository.dart | 0% | 100% | 100% | 0% | 10, 12–14, 20–21, 24–25, 28–29, 8 |
kanji_repository.dart | 0% | 100% | 100% | 0% | 7–8 |
vocabulary_repository.dart | 0% | 100% | 100% | 0% | 7–8 |
lib/src/core/services | |||||
kana_service.dart | 0% | 100% | 100% | 0% | 10–12, 15, 17–18, 21, 25–26, 29–30, 32, 35–36, 39–40 |
kanji_service.dart | 0% | 100% | 100% | 0% | 10, 9 |
vocabulary_service.dart | 0% | 100% | 100% | 0% | 10, 9 |
J'ai mis à jour la PR du code, ajouté les tests unitaires. Par contre, j'ai créé 3 widgets pour gérer les kanas, kanjis et vocabulaire. Si on fusionne les kanjis et le vocabulaire il faudrait qu'on ait une structure similaire entre les deux pour être capable d'afficher facilement les infos dans chaque tile.
Coverage after merging issue_93 into main will be
39.97% |
---|
File | Stmts | Branches | Funcs | Lines | Uncovered Lines |
---|---|---|---|---|---|
lib/src | |||||
locator.dart | 2.33% | 100% | 100% | 2.33% | 26–27, 30–35, 40–41, 44, 46–47, 56–68, 71–73, 75–78, 80–83, 85–88, 90 |
lib/src/core/repositories | |||||
kana_repository.dart | 0% | 100% | 100% | 0% | 10–12, 16–17, 19, 24–26, 29–33, 36–40, 9 |
kanji_repository.dart | 0% | 100% | 100% | 0% | 10–11, 13–14, 9 |
vocabulary_repository.dart | 0% | 100% | 100% | 0% | 10, 12–13, 8–9 |
lib/src/core/services | |||||
kana_service.dart | 0% | 100% | 100% | 0% | 10–12, 15, 17–18, 21, 25–26, 29–30, 32, 35–36, 39–40 |
kanji_service.dart | 0% | 100% | 100% | 0% | 10, 9 |
vocabulary_service.dart | 0% | 100% | 100% | 0% | 10, 9 |
lib/src/glossary/widgets | |||||
kanji_list.dart | 100% | 100% | 100% | 100% | |
kanji_list_tile.dart | 100% | 100% | 100% | 100% | |
vocabulary_list.dart | 100% | 100% | 100% | 100% | |
vocabulary_list_tile.dart | 100% | 100% | 100% | 100% | |
kana_list.dart | 100% | 100% | 100% | 100% | |
kana_list_tile.dart | 100% | 100% | 100% | 100% |
Bon, les builds ne passent pas et les erreurs ne me parle pas du tout...
Coverage after merging issue_93 into main will be
39.97% |
---|
File | Stmts | Branches | Funcs | Lines | Uncovered Lines |
---|---|---|---|---|---|
lib/src | |||||
locator.dart | 2.33% | 100% | 100% | 2.33% | 26–27, 30–35, 40–41, 44, 46–47, 56–68, 71–73, 75–78, 80–83, 85–88, 90 |
lib/src/core/repositories | |||||
kana_repository.dart | 0% | 100% | 100% | 0% | 10–12, 16–17, 19, 24–26, 29–33, 36–40, 9 |
kanji_repository.dart | 0% | 100% | 100% | 0% | 10–11, 13–14, 9 |
vocabulary_repository.dart | 0% | 100% | 100% | 0% | 10, 12–13, 8–9 |
lib/src/core/services | |||||
kana_service.dart | 0% | 100% | 100% | 0% | 10–12, 15, 17–18, 21, 25–26, 29–30, 32, 35–36, 39–40 |
kanji_service.dart | 0% | 100% | 100% | 0% | 10, 9 |
vocabulary_service.dart | 0% | 100% | 100% | 0% | 10, 9 |
lib/src/glossary/widgets | |||||
kanji_list.dart | 100% | 100% | 100% | 100% | |
kanji_list_tile.dart | 100% | 100% | 100% | 100% | |
vocabulary_list.dart | 100% | 100% | 100% | 100% | |
vocabulary_list_tile.dart | 100% | 100% | 100% | 100% | |
kana_list.dart | 100% | 100% | 100% | 100% | |
kana_list_tile.dart | 100% | 100% | 100% | 100% |
Coverage after merging issue_93 into main will be
39.97% |
---|
File | Stmts | Branches | Funcs | Lines | Uncovered Lines |
---|---|---|---|---|---|
lib/src | |||||
locator.dart | 2.33% | 100% | 100% | 2.33% | 26–27, 30–35, 40–41, 44, 46–47, 56–68, 71–73, 75–78, 80–83, 85–88, 90 |
lib/src/core/repositories | |||||
kana_repository.dart | 0% | 100% | 100% | 0% | 10–12, 16–17, 19, 24–26, 29–33, 36–40, 9 |
kanji_repository.dart | 0% | 100% | 100% | 0% | 10–11, 13–14, 9 |
vocabulary_repository.dart | 0% | 100% | 100% | 0% | 10, 12–13, 8–9 |
lib/src/core/services | |||||
kana_service.dart | 0% | 100% | 100% | 0% | 10–12, 15, 17–18, 21, 25–26, 29–30, 32, 35–36, 39–40 |
kanji_service.dart | 0% | 100% | 100% | 0% | 10, 9 |
vocabulary_service.dart | 0% | 100% | 100% | 0% | 10, 9 |
lib/src/glossary/widgets | |||||
kanji_list.dart | 100% | 100% | 100% | 100% | |
kanji_list_tile.dart | 100% | 100% | 100% | 100% | |
vocabulary_list.dart | 100% | 100% | 100% | 100% | |
vocabulary_list_tile.dart | 100% | 100% | 100% | 100% | |
kana_list.dart | 100% | 100% | 100% | 100% | |
kana_list_tile.dart | 100% | 100% | 100% | 100% |
Coverage after merging issue_93 into main will be
39.97% |
---|
File | Stmts | Branches | Funcs | Lines | Uncovered Lines |
---|---|---|---|---|---|
lib/src | |||||
locator.dart | 2.33% | 100% | 100% | 2.33% | 26–27, 30–35, 40–41, 44, 46–47, 56–68, 71–73, 75–78, 80–83, 85–88, 90 |
lib/src/core/repositories | |||||
kana_repository.dart | 0% | 100% | 100% | 0% | 10–12, 16–17, 19, 24–26, 29–33, 36–40, 9 |
kanji_repository.dart | 0% | 100% | 100% | 0% | 10–11, 13–14, 9 |
vocabulary_repository.dart | 0% | 100% | 100% | 0% | 10, 12–13, 8–9 |
lib/src/core/services | |||||
kana_service.dart | 0% | 100% | 100% | 0% | 10–12, 15, 17–18, 21, 25–26, 29–30, 32, 35–36, 39–40 |
kanji_service.dart | 0% | 100% | 100% | 0% | 10, 9 |
vocabulary_service.dart | 0% | 100% | 100% | 0% | 10, 9 |
lib/src/glossary/widgets | |||||
kanji_list.dart | 100% | 100% | 100% | 100% | |
kanji_list_tile.dart | 100% | 100% | 100% | 100% | |
vocabulary_list.dart | 100% | 100% | 100% | 100% | |
vocabulary_list_tile.dart | 100% | 100% | 100% | 100% | |
kana_list.dart | 100% | 100% | 100% | 100% | |
kana_list_tile.dart | 100% | 100% | 100% | 100% |
Coverage after merging issue_93 into main will be
38.99% |
---|
File | Stmts | Branches | Funcs | Lines | Uncovered Lines |
---|---|---|---|---|---|
lib/src | |||||
locator.dart | 2.33% | 100% | 100% | 2.33% | 26–27, 30–35, 40–41, 44, 46–47, 56–68, 71–73, 75–78, 80–83, 85–88, 90 |
lib/src/core/repositories | |||||
kana_repository.dart | 0% | 100% | 100% | 0% | 10–12, 16–17, 19, 24–26, 29–33, 36–40, 9 |
kanji_repository.dart | 0% | 100% | 100% | 0% | 10–11, 13–14, 9 |
vocabulary_repository.dart | 0% | 100% | 100% | 0% | 10, 12–13, 8–9 |
lib/src/core/services | |||||
kana_service.dart | 0% | 100% | 100% | 0% | 10–12, 15, 17–18, 21, 25–26, 29–30, 32, 35–36, 39–40 |
kanji_service.dart | 0% | 100% | 100% | 0% | 10, 9 |
vocabulary_service.dart | 0% | 100% | 100% | 0% | 10, 9 |
lib/src/glossary/widgets | |||||
kanji_list.dart | 100% | 100% | 100% | 100% | |
kanji_list_tile.dart | 100% | 100% | 100% | 100% | |
vocabulary_list.dart | 100% | 100% | 100% | 100% | |
vocabulary_list_tile.dart | 100% | 100% | 100% | 100% | |
kana_list.dart | 100% | 100% | 100% | 100% | |
kana_list_tile.dart | 100% | 100% | 100% | 100% |
📖 Description
Define the glossary skeleton and display data in each tab.
⁉️ Related Issues
closes #93
🖼️ Screenshots:
Glossary
![image](https://github.com/RoadTripMoustache/kana_to_kanji/assets/36586573/abdb8c27-fb60-4253-85f2-15266827fca3)🧪 How to test the change?
☑️ Checklist before requesting a review
version: Major
,version: Minor
orversion: Patch
.