RoadTripMoustache / kana_to_kanji

Simple application to learn Japanese kana (hiragana, katakana) and kanji
5 stars 1 forks source link

feat: Search a kanji, kana, vocabulary in the glossary #98 #108

Closed Adaendra closed 6 months ago

Adaendra commented 8 months ago

๐Ÿ“– Description

Add a search bar in the glossary section.

โ‰๏ธ Related Issues

closes: #98

๐Ÿ–ผ๏ธ Screenshots:

App bar opened ![Screenshot_20231202_075302](https://github.com/RoadTripMoustache/kana_to_kanji/assets/36586573/9c8feaa8-fde5-4661-b59f-02ee65f15ca7)
App bar with a search made ![Screenshot_20231202_075334](https://github.com/RoadTripMoustache/kana_to_kanji/assets/36586573/cf8803b7-e302-4205-b439-b907cf172d4c)

๐Ÿงช How to test the change?

  1. Open the app
  2. Go to the "Glossary"
  3. Use the search bar by clicking on the "search" icon

โ˜‘๏ธ Checklist before requesting a review

github-actions[bot] commented 8 months ago

Bump version from 0.12.0+1 to 0.13.0+1

github-actions[bot] commented 8 months ago

Coverage after merging issue_98 into main will be

41.86%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/core/repositories
   kana_repository.dart0%100%100%0%10–12, 19–20, 22, 27–29, 35–39, 42–48, 51–57, 63–67, 70–76, 79–85, 9
   kanji_repository.dart0%100%100%0%10–11, 13–14, 19–25, 28–40, 9
   vocabulary_repository.dart0%100%100%0%10, 12–13, 18–26, 29–34, 8–9
lib/src/glossary/widgets
   search_bar.dart92.13%100%100%92.13%139–143, 145, 182, 186, 232–233
github-actions[bot] commented 8 months ago

Coverage after merging issue_98 into main will be

41.86%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/core/repositories
   kana_repository.dart0%100%100%0%10–12, 19–20, 22, 27–29, 35–39, 42–48, 51–57, 63–67, 70–76, 79–85, 9
   kanji_repository.dart0%100%100%0%10–11, 13–14, 19–25, 28–40, 9
   vocabulary_repository.dart0%100%100%0%10, 12–13, 18–26, 29–34, 8–9
lib/src/glossary/widgets
   search_bar.dart92.13%100%100%92.13%139–143, 145, 182, 186, 232–233
github-actions[bot] commented 8 months ago

Coverage after merging issue_98 into main will be

41.72%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/core/repositories
   kana_repository.dart0%100%100%0%10–12, 16–17, 19, 24–26, 29–33, 36–43, 45–49, 52–58, 61–65, 68–75, 77–81, 84–89, 9, 90
   kanji_repository.dart0%100%100%0%10–11, 13–14, 19–23, 25, 28–33, 35–36, 38, 9
   vocabulary_repository.dart0%100%100%0%10, 12–13, 18–23, 25, 28–33, 8–9
lib/src/glossary/widgets
   search_bar.dart92.13%100%100%92.13%139–143, 145, 182, 186, 232–233
github-actions[bot] commented 8 months ago

Coverage after merging issue_98 into main will be

41.72%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/core/repositories
   kana_repository.dart0%100%100%0%10–12, 16–17, 19, 24–26, 29–33, 36–43, 45–49, 52–58, 61–65, 68–75, 77–81, 84–89, 9, 90
   kanji_repository.dart0%100%100%0%10–11, 13–14, 19–23, 25, 28–33, 35–36, 38, 9
   vocabulary_repository.dart0%100%100%0%10, 12–13, 18–23, 25, 28–33, 8–9
lib/src/glossary/widgets
   search_bar.dart92.13%100%100%92.13%139–143, 145, 182, 186, 232–233
github-actions[bot] commented 7 months ago

Coverage after merging issue_98 into main will be

41.99%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/core/repositories
   kana_repository.dart0%100%100%0%10–12, 16–17, 19, 24–26, 29–33, 36–39, 41–45, 48–54, 57–61, 64–67, 69–73, 76–82, 9
   kanji_repository.dart0%100%100%0%10–11, 13–14, 19–23, 25, 28–33, 35–36, 38, 9
   vocabulary_repository.dart0%100%100%0%10, 12–13, 18–23, 25, 28–33, 8–9
lib/src/glossary/widgets
   search_bar.dart97.41%100%100%97.41%130, 167, 171
github-actions[bot] commented 7 months ago

Coverage after merging issue_98 into main will be

41.99%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/core/repositories
   kana_repository.dart0%100%100%0%10–12, 16–17, 19, 24–26, 29–33, 36–39, 41–45, 48–54, 57–61, 64–67, 69–73, 76–82, 9
   kanji_repository.dart0%100%100%0%10–11, 13–14, 19–23, 25, 28–33, 35–36, 38, 9
   vocabulary_repository.dart0%100%100%0%10, 12–13, 18–23, 25, 28–33, 8–9
lib/src/glossary/widgets
   search_bar.dart97.41%100%100%97.41%130, 167, 171
github-actions[bot] commented 6 months ago

Coverage after merging issue_98 into main will be

41.99%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/core/repositories
   kana_repository.dart0%100%100%0%10–12, 16–17, 19, 24–26, 29–33, 36–39, 41–45, 48–54, 57–61, 64–67, 69–73, 76–82, 9
   kanji_repository.dart0%100%100%0%10–11, 13–14, 19–23, 25, 28–33, 35–36, 38, 9
   vocabulary_repository.dart0%100%100%0%10, 12–13, 18–23, 25, 28–33, 8–9
lib/src/glossary/widgets
   search_bar.dart97.41%100%100%97.41%130, 167, 171
github-actions[bot] commented 6 months ago

Coverage after merging issue_98 into main will be

42.38%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/core/repositories
   kana_repository.dart0%100%100%0%10–12, 16–17, 19, 24–26, 29–33, 36–39, 41–45, 48–54, 57–61, 64–67, 69–73, 76–82, 9
   kanji_repository.dart0%100%100%0%10–11, 13–14, 19–23, 25, 28–33, 35–36, 38, 9
   vocabulary_repository.dart0%100%100%0%10, 12–13, 18–23, 25, 28–33, 8–9
lib/src/glossary/widgets
   search_bar.dart97.62%100%100%97.62%130, 167, 171