RoadTripMoustache / kana_to_kanji

Simple application to learn Japanese kana (hiragana, katakana) and kanji
5 stars 1 forks source link

feat: Filter by option #96 #109

Closed Adaendra closed 6 months ago

Adaendra commented 8 months ago

๐Ÿ“– Description

Add filters on Glossary

โ‰๏ธ Related Issues

closes #96

๐Ÿ–ผ๏ธ Screenshots:

Filter by screen ![Screenshot_20231204_191643](https://github.com/RoadTripMoustache/kana_to_kanji/assets/36586573/9029043b-1864-40c5-8be4-94b24ed0347d)

๐Ÿงช How to test the change?

  1. Go to the glossary
  2. Click on the "tune" button
  3. Select elements in all the filters options
  4. Click on the "close" button

โ˜‘๏ธ Checklist before requesting a review

github-actions[bot] commented 8 months ago

Coverage after merging issue_96 into issue_98 will be

43.95%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/core/constants
   jlpt_level.dart0%100%100%0%12, 14, 16, 18, 20
lib/src/core/repositories
   kana_repository.dart0%100%100%0%11–14, 21–22, 24, 29–31, 37–41, 44, 46–51, 54–55, 57, 59–63, 69–73, 76, 78–83, 86–87, 89, 91–95
   kanji_repository.dart0%100%100%0%11–13, 15–16, 21, 25–41, 44–45, 47, 50–53, 55–59
   vocabulary_repository.dart0%100%100%0%11–13, 15–16, 21, 25–36, 39–40, 42, 45–48, 51–55
lib/src/glossary/widgets
   filter_by.dart80.16%100%100%80.16%100, 117, 134, 151, 168, 196–197, 216–217, 235–236, 255–256, 33–35, 37, 39–40, 44–46, 48, 50–51
   search_bar.dart85.21%100%100%85.21%165–169, 171, 175–180, 182, 188, 190–191, 231, 235–236, 283–284
github-actions[bot] commented 8 months ago

Coverage after merging issue_96 into issue_98 will be

43.95%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/core/constants
   jlpt_level.dart0%100%100%0%12, 14, 16, 18, 20
lib/src/core/repositories
   kana_repository.dart0%100%100%0%11–14, 21–22, 24, 29–31, 37–41, 44, 46–51, 54–55, 57, 59–63, 69–73, 76, 78–83, 86–87, 89, 91–95
   kanji_repository.dart0%100%100%0%11–13, 15–16, 21, 25–41, 44–45, 47, 50–53, 55–59
   vocabulary_repository.dart0%100%100%0%11–13, 15–16, 21, 25–36, 39–40, 42, 45–48, 51–55
lib/src/glossary/widgets
   filter_by.dart80.16%100%100%80.16%100, 117, 134, 151, 168, 196–197, 216–217, 235–236, 255–256, 33–35, 37, 39–40, 44–46, 48, 50–51
   search_bar.dart85.21%100%100%85.21%165–169, 171, 175–180, 182, 188, 190–191, 231, 235–236, 283–284
github-actions[bot] commented 8 months ago

Coverage after merging issue_96 into issue_98 will be

43.95%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/core/constants
   jlpt_level.dart0%100%100%0%12, 14, 16, 18, 20
lib/src/core/repositories
   kana_repository.dart0%100%100%0%11–14, 21–22, 24, 29–31, 37–41, 44, 46–51, 54–55, 57, 59–63, 69–73, 76, 78–83, 86–87, 89, 91–95
   kanji_repository.dart0%100%100%0%11–13, 15–16, 21, 25–41, 44–45, 47, 50–53, 55–59
   vocabulary_repository.dart0%100%100%0%11–13, 15–16, 21, 25–36, 39–40, 42, 45–48, 51–55
lib/src/glossary/widgets
   search_bar.dart85.21%100%100%85.21%165–169, 171, 175–180, 182, 188, 190–191, 231, 235–236, 283–284
   filter_by.dart80.16%100%100%80.16%100, 117, 134, 151, 168, 196–197, 216–217, 235–236, 255–256, 33–35, 37, 39–40, 44–46, 48, 50–51
github-actions[bot] commented 8 months ago

Coverage after merging issue_96 into issue_98 will be

43.95%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/core/constants
   jlpt_level.dart0%100%100%0%12, 14, 16, 18, 20
lib/src/core/repositories
   kana_repository.dart0%100%100%0%11–14, 18–19, 21, 26–28, 31–35, 38, 40–45, 48–49, 51, 53–57, 60–64, 67, 69–74, 77–78, 80, 82–86
   kanji_repository.dart0%100%100%0%11–13, 15–16, 21, 25–41, 44–45, 47, 50–53, 55–59
   vocabulary_repository.dart0%100%100%0%11–13, 15–16, 21, 25–36, 39–40, 42, 45–48, 51–55
lib/src/glossary/widgets
   search_bar.dart85.21%100%100%85.21%165–169, 171, 175–180, 182, 188, 190–191, 231, 235–236, 283–284
   filter_by.dart80.16%100%100%80.16%100, 117, 134, 151, 168, 196–197, 216–217, 235–236, 255–256, 33–35, 37, 39–40, 44–46, 48, 50–51
github-actions[bot] commented 8 months ago

Coverage after merging issue_96 into issue_98 will be

44.01%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/core/constants
   jlpt_level.dart0%100%100%0%12, 14, 16, 18, 20
lib/src/core/repositories
   kana_repository.dart0%100%100%0%11–14, 18–19, 21, 26–28, 31–35, 38, 41–42, 45–50, 53–54, 56, 58–62, 65–69, 72, 75–76, 79–84, 87–88, 90, 92–96
   kanji_repository.dart0%100%100%0%11–13, 15–16, 21, 25–41, 44–45, 47, 50–53, 55–59
   vocabulary_repository.dart0%100%100%0%11–13, 15–16, 21, 25–36, 39–40, 42, 45–48, 51–55
lib/src/glossary/widgets
   filter_by.dart80.92%100%100%80.92%101, 119, 137, 155, 173, 201–202, 221–222, 240–241, 260–261, 33–35, 37, 39–40, 44–46, 48, 50–51
   search_bar.dart85.21%100%100%85.21%165–169, 171, 175–180, 182, 188, 190–191, 231, 235–236, 283–284
github-actions[bot] commented 8 months ago

Coverage after merging issue_96 into issue_98 will be

44.01%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/core/constants
   jlpt_level.dart0%100%100%0%12, 14, 16, 18, 20
lib/src/core/repositories
   kana_repository.dart0%100%100%0%11–14, 18–19, 21, 26–28, 31–35, 38, 41–42, 45–50, 53–54, 56, 58–62, 65–69, 72, 75–76, 79–84, 87–88, 90, 92–96
   kanji_repository.dart0%100%100%0%11–13, 15–16, 21, 25–41, 44–45, 47, 50–53, 55–59
   vocabulary_repository.dart0%100%100%0%11–13, 15–16, 21, 25–36, 39–40, 42, 45–48, 51–55
lib/src/glossary/widgets
   search_bar.dart85.21%100%100%85.21%165–169, 171, 175–180, 182, 188, 190–191, 231, 235–236, 283–284
   filter_by.dart80.92%100%100%80.92%101, 119, 137, 155, 173, 201–202, 221–222, 240–241, 260–261, 33–35, 37, 39–40, 44–46, 48, 50–51
github-actions[bot] commented 8 months ago

Coverage after merging issue_96 into issue_98 will be

44.01%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/core/constants
   jlpt_level.dart0%100%100%0%12, 14, 16, 18, 20
lib/src/core/repositories
   kana_repository.dart0%100%100%0%11–14, 18–19, 21, 26–28, 31–35, 38, 41–42, 45–50, 53–54, 56, 58–62, 65–69, 72, 75–76, 79–84, 87–88, 90, 92–96
   kanji_repository.dart0%100%100%0%11–13, 15–16, 21, 25–41, 44–45, 47, 50–53, 55–59
   vocabulary_repository.dart0%100%100%0%11–13, 15–16, 21, 25–36, 39–40, 42, 45–48, 51–55
lib/src/glossary/widgets
   search_bar.dart85.21%100%100%85.21%165–169, 171, 175–180, 182, 188, 190–191, 231, 235–236, 283–284
   filter_by.dart80.92%100%100%80.92%101, 119, 137, 155, 173, 201–202, 221–222, 240–241, 260–261, 33–35, 37, 39–40, 44–46, 48, 50–51
github-actions[bot] commented 7 months ago

Coverage after merging issue_96 into issue_98 will be

42.45%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/core/constants
   jlpt_level.dart0%100%100%0%12, 14, 16, 18, 20
   knowledge_level.dart100%100%100%100%
lib/src/core/repositories
   kana_repository.dart0%100%100%0%11–14, 18–19, 21, 26–28, 31–35, 38, 41–42, 45–50, 53–54, 56, 58–62, 65–69, 72, 75–76, 79–84, 87–88, 90, 92–96
   kanji_repository.dart0%100%100%0%11–13, 15–16, 21, 25–41, 44–45, 47, 50–53, 55–59
   vocabulary_repository.dart0%100%100%0%11–13, 15–16, 21, 25–36, 39–40, 42, 45–48, 51–55
lib/src/glossary/widgets
   search_bar.dart89.31%100%100%89.31%156, 160–165, 167, 173, 175–176, 216, 220–221
   filter_by.dart74.58%100%100%74.58%101, 129–130, 33–35, 37, 39–40, 44–46, 48, 50–51
github-actions[bot] commented 6 months ago

Bump version from 0.14.0+1 to 0.15.0+1

github-actions[bot] commented 6 months ago

Coverage after merging issue_96 into main will be

45.03%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/core/constants
   jlpt_level.dart0%100%100%0%12, 14, 16, 18, 20
   knowledge_level.dart100%100%100%100%
lib/src/core/repositories
   kana_repository.dart0%100%100%0%11–14, 18–19, 21, 26–28, 31–35, 38, 41–42, 45–50, 53–54, 56, 58–62, 65–69, 72, 75–76, 79–84, 87–88, 90, 92–96
   kanji_repository.dart0%100%100%0%11–13, 15–16, 21, 25–41, 44–45, 47, 50–53, 55–59
   vocabulary_repository.dart0%100%100%0%11–13, 15–16, 21, 25–36, 39–40, 42, 45–48, 51–55
lib/src/glossary/widgets
   search_bar.dart90.07%100%100%90.07%156, 160–165, 167, 173, 175–176, 216, 220–221
   filter_by.dart74.58%100%100%74.58%101, 129–130, 33–35, 37, 39–40, 44–46, 48, 50–51
github-actions[bot] commented 6 months ago

Coverage after merging issue_96 into main will be

46.71%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/core/constants
   jlpt_levels.dart50%100%100%50%38, 40, 42, 44, 46
   knowledge_level.dart100%100%100%100%
lib/src/core/repositories
   kana_repository.dart38.18%100%100%38.18%100–102, 44, 47–48, 51–56, 59–60, 62, 64–68, 78, 81–82, 85–90, 93–94, 96, 98–99
   kanji_repository.dart18.92%100%100%18.92%29, 33–49, 52–53, 55, 58–61, 63–67
   vocabulary_repository.dart21.88%100%100%21.88%29, 33–44, 47–48, 50, 53–56, 59–63
lib/src/glossary/widgets
   search_bar.dart90.07%100%100%90.07%156, 160–165, 167, 173, 175–176, 216, 220–221
   filter_by.dart70.83%100%100%70.83%107, 33–35, 37, 39–40, 44–46, 48, 50–51, 91
github-actions[bot] commented 6 months ago

Bump version from 0.15.0+1 to 0.16.0+1

github-actions[bot] commented 6 months ago

Bump version from 0.15.0+1 to 0.16.0+1

github-actions[bot] commented 6 months ago

Bump version from 0.15.0+1 to 0.16.0+1

github-actions[bot] commented 6 months ago

Coverage after merging issue_96 into main will be

48.04%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/core/constants
   jlpt_levels.dart50%100%100%50%38, 40, 42, 44, 46
lib/src/core/repositories
   kana_repository.dart38.18%100%100%38.18%100–102, 44, 47–48, 51–56, 59–60, 62, 64–68, 78, 81–82, 85–90, 93–94, 96, 98–99
   kanji_repository.dart18.92%100%100%18.92%29, 33–49, 52–53, 55, 58–61, 63–67
   vocabulary_repository.dart21.88%100%100%21.88%29, 33–44, 47–48, 50, 53–56, 59–63
lib/src/glossary/widgets
   search_bar.dart90.07%100%100%90.07%156, 160–165, 167, 173, 175–176, 216, 220–221
   filter_by.dart75.86%100%100%75.86%108, 124, 33–35, 37, 39–40, 44–46, 48, 50–51
github-actions[bot] commented 6 months ago

Coverage after merging issue_96 into main will be

48.04%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/core/constants
   jlpt_levels.dart50%100%100%50%38, 40, 42, 44, 46
lib/src/core/repositories
   kana_repository.dart38.18%100%100%38.18%100–102, 44, 47–48, 51–56, 59–60, 62, 64–68, 78, 81–82, 85–90, 93–94, 96, 98–99
   kanji_repository.dart18.92%100%100%18.92%29, 33–49, 52–53, 55, 58–61, 63–67
   vocabulary_repository.dart21.88%100%100%21.88%29, 33–44, 47–48, 50, 53–56, 59–63
lib/src/glossary/widgets
   search_bar.dart90.07%100%100%90.07%156, 160–165, 167, 173, 175–176, 216, 220–221
   filter_by.dart75.86%100%100%75.86%108, 124, 33–35, 37, 39–40, 44–46, 48, 50–51