search

RoadTripMoustache / kana_to_kanji

Simple application to learn Japanese kana (hiragana, katakana) and kanji
5 stars 1 forks source link

feat: Sort by #97 #111

Closed Adaendra closed 6 months ago

Adaendra commented 8 months ago

📖 Description

Add sorting feature in the Glossary

⁉️ Related Issues

closes: #97

🖼️ Screenshots:

Sort by panel ![image](https://github.com/RoadTripMoustache/kana_to_kanji/assets/36586573/4f90e31b-9bc4-4c30-8020-cac9c18f8aa0)

🧪 How to test the change?

  1. Open the app
  2. Go to the Glossary
  3. Open the Sort By panel by clicking on the "sort" button
  4. Select an option
  5. Close the panel

☑️ Checklist before requesting a review

github-actions[bot] commented 8 months ago

Coverage after merging issue_97 into issue_96 will be

43.41%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/core/dataloaders
   kanji_dataloader.dart0%100%100%0%15–16, 20, 22–26, 30–36, 38, 40, 46
   vocabulary_dataloader.dart0%100%100%0%15–16, 20, 22–26, 30–36, 42
lib/src/core/models
   kanji.dart50%100%100%50%58
   vocabulary.dart33.33%100%100%33.33%36–37
lib/src/core/repositories
   kana_repository.dart0%100%100%0%102–103, 105, 107–111, 113–114, 116–117, 13–16, 23–24, 26, 31–33, 39–43, 46, 50–55, 58–59, 61, 63–67, 69–70, 72–73, 83–87, 90, 94–99
   kanji_repository.dart0%100%100%0%13–15, 17–18, 23, 28–30, 33–49, 52–53, 55, 58–61, 63–67, 69–71, 73–74
   vocabulary_repository.dart0%100%100%0%13–15, 17–18, 23, 28–30, 32–43, 46–47, 49, 52–55, 58–62, 64–66, 68–69
lib/src/core/utils
   kana_utils.dart0%100%100%0%218–219, 221–223, 230, 232, 234–236, 240, 242
lib/src/glossary/widgets
   sort_by.dart80.65%100%100%80.65%50, 52–53, 64, 66–67
   search_bar.dart79.87%100%100%79.87%177–181, 183, 187–192, 194, 200, 202–203, 210–214, 216, 222, 224–225, 265–266, 271–272, 319–320
github-actions[bot] commented 8 months ago

Coverage after merging issue_97 into issue_96 will be

43.41%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/core/dataloaders
   kanji_dataloader.dart0%100%100%0%15–16, 20, 22–26, 30–36, 38, 40, 46
   vocabulary_dataloader.dart0%100%100%0%15–16, 20, 22–26, 30–36, 42
lib/src/core/models
   kanji.dart50%100%100%50%58
   vocabulary.dart33.33%100%100%33.33%36–37
lib/src/core/repositories
   kana_repository.dart0%100%100%0%102–103, 105, 107–111, 113–114, 116–117, 13–16, 23–24, 26, 31–33, 39–43, 46, 50–55, 58–59, 61, 63–67, 69–70, 72–73, 83–87, 90, 94–99
   kanji_repository.dart0%100%100%0%13–15, 17–18, 23, 28–30, 33–49, 52–53, 55, 58–61, 63–67, 69–71, 73–74
   vocabulary_repository.dart0%100%100%0%13–15, 17–18, 23, 28–30, 32–43, 46–47, 49, 52–55, 58–62, 64–66, 68–69
lib/src/core/utils
   kana_utils.dart0%100%100%0%218–219, 221–223, 230, 232, 234–236, 240, 242
lib/src/glossary/widgets
   sort_by.dart80.65%100%100%80.65%50, 52–53, 64, 66–67
   search_bar.dart79.87%100%100%79.87%177–181, 183, 187–192, 194, 200, 202–203, 210–214, 216, 222, 224–225, 265–266, 271–272, 319–320
github-actions[bot] commented 8 months ago

Coverage after merging issue_97 into issue_96 will be

43.47%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/core/dataloaders
   kanji_dataloader.dart0%100%100%0%15–16, 20, 22–26, 30–36, 38, 40, 46
   vocabulary_dataloader.dart0%100%100%0%15–16, 20, 22–26, 30–36, 42
lib/src/core/models
   kanji.dart50%100%100%50%58
   vocabulary.dart33.33%100%100%33.33%36–37
lib/src/core/repositories
   kana_repository.dart0%100%100%0%100, 103–104, 106, 108–112, 114–115, 117–118, 13–16, 20–21, 23, 28–30, 33–37, 40, 45–46, 49–54, 57–58, 60, 62–66, 68–69, 71–72, 79–83, 86, 91–92, 95–99
   kanji_repository.dart0%100%100%0%13–15, 17–18, 23, 28–30, 33–49, 52–53, 55, 58–61, 63–67, 69–71, 73–74
   vocabulary_repository.dart0%100%100%0%13–15, 17–18, 23, 28–30, 32–43, 46–47, 49, 52–55, 58–62, 64–66, 68–69
lib/src/core/utils
   kana_utils.dart0%100%100%0%218–219, 221–223, 230, 232, 234–236, 240, 242
lib/src/glossary/widgets
   sort_by.dart80.65%100%100%80.65%50, 52–53, 64, 66–67
   search_bar.dart79.87%100%100%79.87%177–181, 183, 187–192, 194, 200, 202–203, 210–214, 216, 222, 224–225, 265–266, 271–272, 319–320
github-actions[bot] commented 8 months ago

Coverage after merging issue_97 into issue_96 will be

43.42%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/core/dataloaders
   kanji_dataloader.dart0%100%100%0%15–16, 20, 22–26, 30–36, 38, 40, 46
   vocabulary_dataloader.dart0%100%100%0%15–16, 20, 22–26, 30–36, 42
lib/src/core/models
   kanji.dart50%100%100%50%58
   vocabulary.dart33.33%100%100%33.33%36–37
lib/src/core/repositories
   kana_repository.dart0%100%100%0%100, 103–104, 106, 108–112, 114–115, 117–118, 13–16, 20–21, 23, 28–30, 33–37, 40, 45–46, 49–54, 57–58, 60, 62–66, 68–69, 71–72, 79–83, 86, 91–92, 95–99
   kanji_repository.dart0%100%100%0%13–15, 17–18, 23, 28–30, 33–49, 52–53, 55, 58–61, 63–67, 69–71, 73–74
   vocabulary_repository.dart0%100%100%0%13–15, 17–18, 23, 28–30, 32–43, 46–47, 49, 52–55, 58–62, 64–66, 68–69
lib/src/core/utils
   kana_utils.dart0%100%100%0%224–225, 227–229, 231–232, 239, 241, 243–245, 249, 251
lib/src/glossary/widgets
   sort_by.dart80.65%100%100%80.65%50, 52–53, 64, 66–67
   search_bar.dart79.87%100%100%79.87%177–181, 183, 187–192, 194, 200, 202–203, 210–214, 216, 222, 224–225, 265–266, 271–272, 319–320
github-actions[bot] commented 8 months ago

Coverage after merging issue_97 into issue_96 will be

43.42%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/core/dataloaders
   kanji_dataloader.dart0%100%100%0%15–16, 20, 22–26, 30–36, 38, 40, 46
   vocabulary_dataloader.dart0%100%100%0%15–16, 20, 22–26, 30–36, 42
lib/src/core/models
   kanji.dart50%100%100%50%58
   vocabulary.dart33.33%100%100%33.33%36–37
lib/src/core/repositories
   kana_repository.dart0%100%100%0%100, 103–104, 106, 108–112, 114–115, 117–118, 13–16, 20–21, 23, 28–30, 33–37, 40, 45–46, 49–54, 57–58, 60, 62–66, 68–69, 71–72, 79–83, 86, 91–92, 95–99
   kanji_repository.dart0%100%100%0%13–15, 17–18, 23, 28–30, 33–49, 52–53, 55, 58–61, 63–67, 69–71, 73–74
   vocabulary_repository.dart0%100%100%0%13–15, 17–18, 23, 28–30, 32–43, 46–47, 49, 52–55, 58–62, 64–66, 68–69
lib/src/core/utils
   kana_utils.dart0%100%100%0%224–225, 227–229, 231–232, 239, 241, 243–245, 249, 251
lib/src/glossary/widgets
   sort_by.dart80.65%100%100%80.65%50, 52–53, 64, 66–67
   search_bar.dart79.87%100%100%79.87%177–181, 183, 187–192, 194, 200, 202–203, 210–214, 216, 222, 224–225, 265–266, 271–272, 319–320
github-actions[bot] commented 7 months ago

Coverage after merging issue_97 into issue_96 will be

41.87%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/core/dataloaders
   kanji_dataloader.dart0%100%100%0%15–16, 20, 22–26, 30–36, 38, 40, 46
   vocabulary_dataloader.dart0%100%100%0%15–16, 20, 22–26, 30–36, 42
lib/src/core/models
   kanji.dart50%100%100%50%58
   vocabulary.dart33.33%100%100%33.33%36–37
lib/src/core/repositories
   kana_repository.dart0%100%100%0%100, 103–104, 106, 108–112, 114–115, 117–118, 13–16, 20–21, 23, 28–30, 33–37, 40, 45–46, 49–54, 57–58, 60, 62–66, 68–69, 71–72, 79–83, 86, 91–92, 95–99
   kanji_repository.dart0%100%100%0%13–15, 17–18, 23, 28–30, 33–49, 52–53, 55, 58–61, 63–67, 69–71, 73–74
   vocabulary_repository.dart0%100%100%0%13–15, 17–18, 23, 28–30, 32–43, 46–47, 49, 52–55, 58–62, 64–66, 68–69
lib/src/core/utils
   kana_utils.dart0%100%100%0%224–225, 227–229, 231–232, 239, 241, 243–245, 249, 251
lib/src/glossary/widgets
   sort_by.dart80.65%100%100%80.65%50, 52–53, 64, 66–67
   search_bar.dart83.22%100%100%83.22%169, 173–178, 180, 186, 188–189, 196–200, 202, 208, 210–211, 251–252, 257–258
github-actions[bot] commented 6 months ago

Coverage after merging issue_97 into issue_96 will be

42.25%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/core/dataloaders
   kanji_dataloader.dart0%100%100%0%15–16, 20, 22–26, 30–36, 38, 40, 46
   vocabulary_dataloader.dart0%100%100%0%15–16, 20, 22–26, 30–36, 42
lib/src/core/models
   kanji.dart50%100%100%50%58
   vocabulary.dart33.33%100%100%33.33%36–37
lib/src/core/repositories
   kana_repository.dart0%100%100%0%100, 103–104, 106, 108–112, 114–115, 117–118, 13–16, 20–21, 23, 28–30, 33–37, 40, 45–46, 49–54, 57–58, 60, 62–66, 68–69, 71–72, 79–83, 86, 91–92, 95–99
   kanji_repository.dart0%100%100%0%13–15, 17–18, 23, 28–30, 33–49, 52–53, 55, 58–61, 63–67, 69–71, 73–74
   vocabulary_repository.dart0%100%100%0%13–15, 17–18, 23, 28–30, 32–43, 46–47, 49, 52–55, 58–62, 64–66, 68–69
lib/src/core/utils
   kana_utils.dart0%100%100%0%224–225, 227–229, 231–232, 239, 241, 243–245, 249, 251
lib/src/glossary/widgets
   search_bar.dart84.31%100%100%84.31%168, 172–177, 179, 185, 187–188, 195–199, 201, 207, 209–210, 250–251, 256–257
   sort_by.dart80.65%100%100%80.65%50, 52–53, 64, 66–67
github-actions[bot] commented 6 months ago

Coverage after merging issue_97 into issue_96 will be

44.39%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/core/dataloaders
   kanji_dataloader.dart0%100%100%0%15–16, 20, 22–26, 30–36, 38, 40, 46
   vocabulary_dataloader.dart0%100%100%0%15–16, 20, 22–26, 30–36, 42
lib/src/core/models
   kanji.dart50%100%100%50%58
   vocabulary.dart33.33%100%100%33.33%39–40
lib/src/core/repositories
   kana_repository.dart0%100%100%0%100, 103–104, 106, 108–112, 114–115, 117–118, 13–16, 20–21, 23, 28–30, 33–37, 40, 45–46, 49–54, 57–58, 60, 62–66, 68–69, 71–72, 79–83, 86, 91–92, 95–99
   kanji_repository.dart0%100%100%0%13–15, 17–18, 23, 28–30, 33–49, 52–53, 55, 58–61, 63–67, 69–71, 73–74
   vocabulary_repository.dart0%100%100%0%13–15, 17–18, 23, 28–30, 32–43, 46–47, 49, 52–55, 58–62, 64–66, 68–69
lib/src/core/utils
   kana_utils.dart0%100%100%0%224–225, 227–229, 231–232, 239, 241, 243–245, 249, 251
lib/src/glossary/widgets
   search_bar.dart84.31%100%100%84.31%168, 172–177, 179, 185, 187–188, 195–199, 201, 207, 209–210, 250–251, 256–257
   sort_by.dart80.65%100%100%80.65%50, 52–53, 64, 66–67
github-actions[bot] commented 6 months ago

Bump version from 0.16.0+1 to 0.17.0+1

github-actions[bot] commented 6 months ago

Coverage after merging issue_97 into main will be

47.53%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/core/dataloaders
   kanji_dataloader.dart0%100%100%0%15–16, 20, 22–26, 30–36, 38, 40, 46
   vocabulary_dataloader.dart0%100%100%0%15–16, 20, 22–26, 30–36, 42
lib/src/core/models
   kanji.dart50%100%100%50%58
   vocabulary.dart33.33%100%100%33.33%47–48
lib/src/core/repositories
   kanji_repository.dart16.28%100%100%16.28%31, 36, 38–54, 57–58, 60, 63–66, 68–72, 74–76, 78–79
   vocabulary_repository.dart18.42%100%100%18.42%31, 36–48, 51–52, 54, 57–60, 63–67, 69–71, 73–74
lib/src/core/utils
   kana_utils.dart0%100%100%0%224–225, 227–229, 231–232, 239, 241, 243–245, 249, 251
lib/src/glossary/widgets
   search_bar.dart84.31%100%100%84.31%168, 172–177, 179, 185, 187–188, 195–199, 201, 207, 209–210, 250–251, 256–257
   sort_by.dart79.31%100%100%79.31%50, 52–53, 62, 64–65
github-actions[bot] commented 6 months ago

Coverage after merging issue_97 into main will be

47.53%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/core/dataloaders
   kanji_dataloader.dart0%100%100%0%15–16, 20, 22–26, 30–36, 38, 40, 46
   vocabulary_dataloader.dart0%100%100%0%15–16, 20, 22–26, 30–36, 42
lib/src/core/models
   kanji.dart50%100%100%50%58
   vocabulary.dart33.33%100%100%33.33%47–48
lib/src/core/repositories
   kanji_repository.dart16.28%100%100%16.28%31, 36, 38–54, 57–58, 60, 63–66, 68–72, 74–76, 78–79
   vocabulary_repository.dart18.42%100%100%18.42%31, 36–48, 51–52, 54, 57–60, 63–67, 69–71, 73–74
lib/src/core/utils
   kana_utils.dart0%100%100%0%224–225, 227–229, 231–232, 239, 241, 243–245, 249, 251
lib/src/glossary/widgets
   sort_by.dart79.31%100%100%79.31%50, 52–53, 62, 64–65
   search_bar.dart84.31%100%100%84.31%168, 172–177, 179, 185, 187–188, 195–199, 201, 207, 209–210, 250–251, 256–257