RoadTripMoustache / kana_to_kanji

Simple application to learn Japanese kana (hiragana, katakana) and kanji
5 stars 1 forks source link

#100 Implement kana list and list tile #117

Closed apomalyn closed 6 months ago

apomalyn commented 7 months ago

๐Ÿ“– Description

Introduce KanaListTile and also refactor KanaList.

โ‰๏ธ Related Issues

Closes #100

๐Ÿ–ผ๏ธ Screenshots:

Demo https://github.com/RoadTripMoustache/kana_to_kanji/assets/22211097/fa3051a7-bfbc-45fc-bba0-5823bc123ba2
Search demonstration https://github.com/RoadTripMoustache/kana_to_kanji/assets/22211097/bfeee28a-6612-4499-bd3f-b7f14d2af5d6

๐Ÿงช How to test the change?

  1. Open the application
  2. Go to the Glossary tab
  3. See changes you can also go to the Katakana section

โ˜‘๏ธ Checklist before requesting a review

apomalyn commented 7 months ago

I need to add tests for the KanaListTile and that will be ready for review ๐Ÿ˜„

github-actions[bot] commented 7 months ago

Coverage after merging feat/100-kanas into feat/100-repos will be

45.55%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/glossary/widgets
   kana_list.dart86.84%100%100%86.84%14–17, 35
   kana_list_tile.dart100%100%100%100%
github-actions[bot] commented 7 months ago

Coverage after merging feat/100-kanas into feat/100-repos will be

45.55%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/glossary/widgets
   kana_list_tile.dart100%100%100%100%
   kana_list.dart86.84%100%100%86.84%14–17, 35
github-actions[bot] commented 6 months ago

Coverage after merging feat/100-kanas into feat/100-repos will be

45.47%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/glossary/widgets
   glossary_list_tile.dart100%100%100%100%
   kana_list_tile.dart100%100%100%100%
   kana_list.dart86.84%100%100%86.84%14–17, 35
github-actions[bot] commented 6 months ago

Bump version from 0.14.1+1 to 0.15.0+1

github-actions[bot] commented 6 months ago

Coverage after merging feat/100-kanas into main will be

48.29%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/glossary/widgets
   kana_list_tile.dart100%100%100%100%
   kana_list.dart86%100%100%86%21–24, 60, 72, 79
github-actions[bot] commented 6 months ago

Coverage after merging feat/100-kanas into main will be

48.25%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/glossary/widgets
   kana_list_tile.dart100%100%100%100%
   kana_list.dart85.71%100%100%85.71%26–29, 65, 77, 84
github-actions[bot] commented 6 months ago

Coverage after merging feat/100-kanas into main will be

48.25%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/glossary/widgets
   kana_list_tile.dart100%100%100%100%
   kana_list.dart85.71%100%100%85.71%26–29, 65, 77, 84