RoadTripMoustache / kana_to_kanji

Simple application to learn Japanese kana (hiragana, katakana) and kanji
5 stars 1 forks source link

fix: Tapping clear search doesn't clear it #126

Closed Adaendra closed 6 months ago

Adaendra commented 6 months ago

๐Ÿ“– Description

Clear the search input and result list in the glossary, when the clear button is tapped.

โ‰๏ธ Related Issues

closes: #121

๐Ÿงช How to test the change?

  1. Open the glossary search bar
  2. Do a search - It should display only the resources matching with your search
  3. Clear the search by clicking on the "X" button of the search bar - The input is cleared and the list is updated

โ˜‘๏ธ Checklist before requesting a review

github-actions[bot] commented 6 months ago

Bump version from 0.15.0+1 to 0.16.0+1

github-actions[bot] commented 6 months ago

Coverage after merging issue_121 into main will be

48.29%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/glossary/widgets
   search_bar.dart97.64%100%100%97.64%131, 168, 172
github-actions[bot] commented 6 months ago

Bump version from 0.16.0+1 to 0.17.0+1

github-actions[bot] commented 6 months ago

Coverage after merging issue_121 into main will be

48.07%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/glossary/widgets
   search_bar.dart90.14%100%100%90.14%157, 161–166, 168, 174, 176–177, 217, 221–222
github-actions[bot] commented 6 months ago

Bump version from 0.16.0+1 to 0.17.0+1

github-actions[bot] commented 6 months ago

Coverage after merging issue_121 into main will be

48.07%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/glossary/widgets
   search_bar.dart90.14%100%100%90.14%157, 161–166, 168, 174, 176–177, 217, 221–222
github-actions[bot] commented 6 months ago

Bump version from 0.16.0+1 to 0.17.0+1

github-actions[bot] commented 6 months ago

Coverage after merging issue_121 into main will be

48.07%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/glossary/widgets
   search_bar.dart90.14%100%100%90.14%157, 161–166, 168, 174, 176–177, 217, 221–222
github-actions[bot] commented 6 months ago

Coverage after merging issue_121 into main will be

48.07%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/glossary/widgets
   search_bar.dart90.14%100%100%90.14%157, 161–166, 168, 174, 176–177, 217, 221–222
github-actions[bot] commented 6 months ago

Bump version from 0.17.0+1 to 0.18.0+1

github-actions[bot] commented 6 months ago

Coverage after merging issue_121 into main will be

47.56%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/glossary/widgets
   search_bar.dart84.42%100%100%84.42%169, 173–178, 180, 186, 188–189, 196–200, 202, 208, 210–211, 251–252, 257–258