RoadTripMoustache / kana_to_kanji

Simple application to learn Japanese kana (hiragana, katakana) and kanji
5 stars 1 forks source link

feat: Kana, kanji and vocabulary details skeleton #127

Closed apomalyn closed 6 months ago

apomalyn commented 6 months ago

๐Ÿ“– Description

Implement the skeleton for kana, kanji, and vocabulary details view. Please note that TTS will be added in a second PR ๐Ÿ˜„

This will be loaded as a modal bottom sheet adjusted based on the content.

โ‰๏ธ Related Issues

๐Ÿ–ผ๏ธ Screenshots:

Demo! https://github.com/RoadTripMoustache/kana_to_kanji/assets/22211097/e30e6852-de5e-422e-ad0d-714df98f9763

๐Ÿงช How to test the change?

  1. Go to Glossary tab
  2. Select any kana, kanji, or vocabulary
  3. See changes

โ˜‘๏ธ Checklist before requesting a review

github-actions[bot] commented 6 months ago

Bump version from 0.18.0+1 to 0.19.0+1

github-actions[bot] commented 6 months ago

Coverage after merging feat/102 into main will be

50.11%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/core/constants
   app_theme.dart87.50%100%100%87.50%5
lib/src/core/models
   kana.dart50%100%100%50%28
   kanji.dart66.67%100%100%66.67%58
lib/src/core/widgets
   app_spacer.dart75%100%100%75%15, 17
   app_scaffold.dart0%100%100%0%20, 30–34, 37–39, 43–45
lib/src/glossary/details
   details_view.dart100%100%100%100%
   details_view_model.dart100%100%100%100%
lib/src/glossary/details/widgets
   section_title.dart100%100%100%100%
   pronunciation_card.dart83.33%100%100%83.33%8
   details.dart100%100%100%100%
   wrapped_list.dart100%100%100%100%
lib/src/glossary/widgets
   kanji_list.dart55.56%100%100%55.56%13–15, 25
   vocabulary_list.dart60%100%100%60%13–15, 26
   kana_list.dart87.50%100%100%87.50%29–31, 68, 80, 87