RoadTripMoustache / kana_to_kanji

Simple application to learn Japanese kana (hiragana, katakana) and kanji
5 stars 1 forks source link

feat: Implement create account #136

Closed apomalyn closed 1 month ago

apomalyn commented 6 months ago

Requirements

What needs to be done

Dependencies

Child of #130

Depends on:

Dev notes

Adaendra commented 2 months ago

@apomalyn I can implement this process, but were is it used ? An anonymous account don't need to have an email/password, and we don't have a button/link to allow the user to use the application without being logged in.

So, where will be the link/button to allow the user to create an annonymous account ?

If we want to have the user/password only, we should use this.

apomalyn commented 2 months ago

The register (account creation) is different than linkAccount (#138). When a user lands on the application for the first time, it will be redirected to the LandingView (#132) and the Getting started button will trigger the register, creating an anonymous account and the "link" button/banner (#146) will be available on the profile

Adaendra commented 2 months ago

@apomalyn in case of an error in the registration, what are we going to do ?

Also, we need to change the way the app is started. Currently we start on the splash screen which initialize the app, but we won't be able to leave it if we don't have a correct token to call the API.

apomalyn commented 2 months ago

in case of an error in the registration, what are we going to do?

The only reason registration would fail is if the API or Firebase isn't available. In both cases, I guess a classic error message (in a toast) should be enough

Also, we need to change the way the app is started. Currently we start on the splash screen which initialize the app, but we won't be able to leave it if we don't have a correct token to call the API.

Yes, we need to update the splash screen, I see 2 options:

  1. Update the splash screen to first check if a silent login is possible, then go to initialization or to the login screen
  2. Create a new screen Initialization which would contain the actual splash and update the latter to check if silent login is possible