refactor: Kana, Kanji, Vocabulary id into UID - Githubissues

RoadTripMoustache / kana_to_kanji

Simple application to learn Japanese kana (hiragana, katakana) and kanji

5 stars 1 forks source link

refactor: Kana, Kanji, Vocabulary id into UID #216

Closed apomalyn closed 1 month ago

apomalyn commented 2 months ago

Requirements

Implement a ResourceType enum:

Kana: kana-
Kanji: kanji-
Vocabulaire: vocabulary-

Implement a ResourceUid class that:

extract from a given string the ResourceType from the UID

Refactor the Kana, Kanji, and Vocabulary to use ResourceUid as ID.

What needs to be done

Under src/core/constants implement ResourceType enum.
Under src/core/models implement ResourceUid:
- constructor takes:
- ResourceType type
- String uid: full UID
- named constructor .fromString takes:
- String uid, ResourceType will be determined based on the beginning of the string
Refactor Kana, Kanji, and Vocabulary to use ResourceUid as ID, rename the field as uid, (see Isar doc)

Dependencies

Depends on:

https://github.com/RoadTripMoustache/kana_to_kanji_api/issues/65

Dev notes

Isar documentation for String ids