RoadTripMoustache / kana_to_kanji

Simple application to learn Japanese kana (hiragana, katakana) and kanji
5 stars 1 forks source link

refactor: Kana, Kanji, Vocabulary id into UID #235

Closed Adaendra closed 1 month ago

Adaendra commented 1 month ago

๐Ÿ“– Description

Change resources ids to use UID instead.

โ‰๏ธ Related Issues

closes #216

๐Ÿงช How to test the change?

โ˜‘๏ธ Checklist before requesting a review

Notes

  • index and group fields had to be renamed because they are now considered as reserved words
github-actions[bot] commented 1 month ago

Bump version from 0.19.1+1 to 0.20.0+1

github-actions[bot] commented 1 month ago

Bump version from 0.20.2+1 to 0.21.0+1

github-actions[bot] commented 1 month ago

Coverage after merging issue_216 into main will be

49.54%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/core/models
   group.dart66.67%100%100%66.67%34
   kana.dart66.67%100%100%66.67%36
   kanji.dart80%100%100%80%96
   vocabulary.dart25%100%100%25%18, 73–74
   example.dart0%100%100%0%14, 16–17
   resource_uid.dart20%100%100%20%17, 19–20, 23
   pronunciations.dart0%100%100%0%18, 20–21
   kanji_reading.dart0%100%100%0%18, 23, 25–26
lib/src/core/repositories
   kana_repository.dart36.51%100%100%36.51%100–101, 104–109, 112–113, 115, 118–122, 124–125, 45, 51, 54–55, 58–63, 66–67, 69, 71–75, 77–78, 91, 97
lib/src/core/services
   kana_service.dart0%100%100%0%11–13, 17, 19–20, 23, 27–28, 31–32, 34, 37–38, 41–42
lib/src/core/utils
   isar_utils.dart100%100%100%100%
lib/src/core/widgets
   arc_progress_indicator.dart100%100%100%100%
   rounded_linear_progress_indicator.dart0%100%100%0%100, 102–104, 108–111, 113–114, 116–118, 121, 123–124, 127–130, 132, 135, 140, 142–143, 149, 152–156, 158–161, 163, 165–166, 169–170, 172, 190, 195, 197–201, 203–204, 207, 211–212, 214, 217, 219–221, 59, 69, 71, 86, 88–89, 94–95, 97
lib/src/glossary/widgets
   kana_list.dart87.76%100%100%87.76%29–31, 70, 83, 91
lib/src/quiz
   quiz_view_model.dart0%100%100%0%22, 26, 28–29, 31, 33, 35, 37–40, 43–44, 47–49, 52–53, 55–57, 60, 65–67, 69–70
github-actions[bot] commented 1 month ago

Coverage after merging issue_216 into main will be

49.54%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/core/models
   group.dart66.67%100%100%66.67%34
   kana.dart66.67%100%100%66.67%36
   kanji.dart80%100%100%80%96
   vocabulary.dart25%100%100%25%18, 73–74
   example.dart0%100%100%0%14, 16–17
   resource_uid.dart20%100%100%20%17, 19–20, 23
   pronunciations.dart0%100%100%0%18, 20–21
   kanji_reading.dart0%100%100%0%18, 23, 25–26
lib/src/core/repositories
   kana_repository.dart36.51%100%100%36.51%100–101, 104–109, 112–113, 115, 118–122, 124–125, 45, 51, 54–55, 58–63, 66–67, 69, 71–75, 77–78, 91, 97
lib/src/core/services
   kana_service.dart0%100%100%0%11–13, 17, 19–20, 23, 27–28, 31–32, 34, 37–38, 41–42
lib/src/core/utils
   isar_utils.dart100%100%100%100%
lib/src/glossary/widgets
   kana_list.dart87.76%100%100%87.76%29–31, 70, 83, 91
lib/src/quiz
   quiz_view_model.dart0%100%100%0%22, 26, 28–29, 31, 33, 35, 37–40, 43–44, 47–49, 52–53, 55–57, 60, 65–67, 69–70
github-actions[bot] commented 1 month ago

Coverage after merging issue_216 into main will be

49.54%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/core/models
   group.dart66.67%100%100%66.67%34
   kana.dart66.67%100%100%66.67%36
   kanji.dart80%100%100%80%96
   vocabulary.dart25%100%100%25%18, 73–74
   example.dart0%100%100%0%14, 16–17
   resource_uid.dart20%100%100%20%17, 19–20, 23
   pronunciations.dart0%100%100%0%18, 20–21
   kanji_reading.dart0%100%100%0%18, 23, 25–26
lib/src/core/repositories
   kana_repository.dart36.51%100%100%36.51%100–101, 104–109, 112–113, 115, 118–122, 124–125, 45, 51, 54–55, 58–63, 66–67, 69, 71–75, 77–78, 91, 97
lib/src/core/services
   kana_service.dart0%100%100%0%11–13, 17, 19–20, 23, 27–28, 31–32, 34, 37–38, 41–42
lib/src/core/utils
   isar_utils.dart100%100%100%100%
lib/src/glossary/widgets
   kana_list.dart87.76%100%100%87.76%29–31, 70, 83, 91
lib/src/quiz
   quiz_view_model.dart0%100%100%0%22, 26, 28–29, 31, 33, 35, 37–40, 43–44, 47–49, 52–53, 55–57, 60, 65–67, 69–70