RoadTripMoustache / kana_to_kanji

Simple application to learn Japanese kana (hiragana, katakana) and kanji
5 stars 1 forks source link

fix: Only execute search, filter and sort on the current tab #252

Closed Adaendra closed 1 month ago

Adaendra commented 1 month ago

Prerequisites

Related PR

📖 Description

Update code to execute search, filter and sort, only on the current tab. If a search / filter / sort is made while being on a tab (like Kanji), the update will be made on the others when the user will select a other tab.

⁉️ Related Issues

closes : #116

🖼️ Screenshots:

Test that it doesn't break everything [issue_116.webm](https://github.com/RoadTripMoustache/kana_to_kanji/assets/36586573/93956e0c-3313-4127-8682-6afb9cced142)

🧪 How to test the change?

☑️ Checklist before requesting a review

github-actions[bot] commented 1 month ago

Coverage after merging issue_116 into issue_118 will be

47.49%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
github-actions[bot] commented 1 month ago

Coverage after merging issue_116 into issue_118 will be

47.97%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/glossary/widgets
   vocabulary_list.dart75%100%100%75%45–46, 48–49, 61, 65–66
github-actions[bot] commented 1 month ago

Coverage after merging issue_116 into issue_118 will be

47.97%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/glossary/widgets
   vocabulary_list.dart75%100%100%75%45–46, 48–49, 61, 65–66
github-actions[bot] commented 1 month ago

Bump version from 0.26.0+1 to 0.27.0+1

github-actions[bot] commented 1 month ago

Coverage after merging issue_116 into main will be

47.97%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/glossary/widgets
   vocabulary_list.dart75%100%100%75%45–46, 48–49, 61, 65–66
github-actions[bot] commented 1 month ago

Bump version from 0.26.1+1 to 0.27.0+1

github-actions[bot] commented 1 month ago

Coverage after merging issue_116 into main will be

47.97%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/glossary/widgets
   vocabulary_list.dart75%100%100%75%45–46, 48–49, 61, 65–66
github-actions[bot] commented 1 month ago

Coverage after merging issue_116 into main will be

47.97%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/glossary/widgets
   vocabulary_list.dart75%100%100%75%45–46, 48–49, 61, 65–66
github-actions[bot] commented 1 month ago

Bump version from 0.27.0+1 to 0.28.0+1

github-actions[bot] commented 1 month ago

Coverage after merging issue_116 into main will be

48.42%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/glossary/widgets
   vocabulary_list.dart75%100%100%75%45–46, 48–49, 61, 65–66
Adaendra commented 1 month ago

Est-ce que tu penses pouvoir ajouter un test ici pour valider que les calls se déclenchent uniquement quand on change de tab?

Tests ajoutés

github-actions[bot] commented 1 month ago

Coverage after merging issue_116 into main will be

49.61%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/core/constants
   glossary_tab.dart100%100%100%100%
lib/src/glossary
   glossary_view_model.dart78.95%100%100%78.95%162–163, 167, 45, 47, 58–61, 73–75, 79–82
lib/src/glossary/widgets
   vocabulary_list.dart75%100%100%75%45–46, 48–49, 61, 65–66