fix: Improve sorting of japanese words

Adaendra commented 1 month ago

Prerequisites

Related PR

📖 Description

Improve sorting of kanji & vocabulary with the japanese order.

⁉️ Related Issues

closes : #128

🧪 How to test the change?

Open the application
Go to the Glossary
Go to the Vocabulary tab
Change the sort filter to alphabetical
Close the sort filter menu
Change the sort filter to japanese order
Close the sort filter menu

☑️ Checklist before requesting a review

[x] I have performed a self-review of my code.
[x] I have added/updated tests.
[x] Make sure to add either one of the following labels: version: Major,version: Minor or version: Patch.

github-actions[bot] commented 1 month ago

Coverage after merging issue_128 into issue_116 will be

47.49%

Coverage Report for Changed Files

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
lib/src/core/models
kanji.dart	80%	100%	100%	80%	96
vocabulary.dart	25%	100%	100%	25%	18, 73–74
lib/src/core/utils
kana_utils.dart	0%	100%	100%	0%	224–225, 227–229, 231–232, 236, 239, 241–243, 247, 249

github-actions[bot] commented 1 month ago

Coverage after merging issue_128 into issue_116 will be

48.15%

Coverage Report for Changed Files

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
lib/src/core/models
kanji.dart	80%	100%	100%	80%	96
vocabulary.dart	25%	100%	100%	25%	18, 73–74
lib/src/core/utils
kana_utils.dart	100%	100%	100%	100%

github-actions[bot] commented 1 month ago

Coverage after merging issue_128 into issue_116 will be

48.64%

Coverage Report for Changed Files

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
lib/src/core/models
kanji.dart	80%	100%	100%	80%	96
vocabulary.dart	25%	100%	100%	25%	17, 74–75
lib/src/core/utils
kana_utils.dart	100%	100%	100%	100%

github-actions[bot] commented 1 month ago

Coverage after merging issue_128 into issue_116 will be

48.64%

Coverage Report for Changed Files

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
lib/src/core/models
kanji.dart	80%	100%	100%	80%	96
vocabulary.dart	25%	100%	100%	25%	17, 74–75
lib/src/core/utils
kana_utils.dart	100%	100%	100%	100%

github-actions[bot] commented 1 month ago

Coverage after merging issue_128 into issue_116 will be

48.64%

Coverage Report for Changed Files

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
lib/src/core/models
kanji.dart	80%	100%	100%	80%	96
vocabulary.dart	25%	100%	100%	25%	17, 74–75
lib/src/core/utils
kana_utils.dart	100%	100%	100%	100%

github-actions[bot] commented 1 month ago

Coverage after merging issue_128 into issue_116 will be

48.64%

Coverage Report for Changed Files

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
lib/src/core/models
kanji.dart	80%	100%	100%	80%	96
vocabulary.dart	25%	100%	100%	25%	17, 74–75
lib/src/core/utils
kana_utils.dart	100%	100%	100%	100%
lib/src/glossary/widgets
vocabulary_list.dart	75%	100%	100%	75%	45–46, 48–49, 61, 65–66

github-actions[bot] commented 1 month ago

Coverage after merging issue_128 into issue_116 will be

48.64%

Coverage Report for Changed Files

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
lib/src/core/models
kanji.dart	80%	100%	100%	80%	96
vocabulary.dart	25%	100%	100%	25%	17, 74–75
lib/src/core/utils
kana_utils.dart	100%	100%	100%	100%
lib/src/glossary/widgets
vocabulary_list.dart	75%	100%	100%	75%	45–46, 48–49, 61, 65–66

github-actions[bot] commented 1 month ago

Coverage after merging issue_128 into issue_116 will be

48.64%

Coverage Report for Changed Files

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
lib/src/core/models
kanji.dart	80%	100%	100%	80%	96
vocabulary.dart	25%	100%	100%	25%	17, 74–75
lib/src/core/utils
kana_utils.dart	100%	100%	100%	100%
lib/src/glossary/widgets
vocabulary_list.dart	75%	100%	100%	75%	45–46, 48–49, 61, 65–66

github-actions[bot] commented 1 month ago

Coverage after merging issue_128 into issue_116 will be

48.64%

Coverage Report for Changed Files

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
lib/src/core/models
kanji.dart	80%	100%	100%	80%	96
vocabulary.dart	25%	100%	100%	25%	17, 74–75
lib/src/core/utils
kana_utils.dart	100%	100%	100%	100%
lib/src/glossary/widgets
vocabulary_list.dart	75%	100%	100%	75%	45–46, 48–49, 61, 65–66

github-actions[bot] commented 1 month ago

Coverage after merging issue_128 into issue_116 will be

49.09%

Coverage Report for Changed Files

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
lib/src/core/models
kanji.dart	80%	100%	100%	80%	96
vocabulary.dart	25%	100%	100%	25%	17, 74–75
lib/src/core/utils
kana_utils.dart	100%	100%	100%	100%
lib/src/glossary/widgets
vocabulary_list.dart	75%	100%	100%	75%	45–46, 48–49, 61, 65–66

github-actions[bot] commented 1 month ago

Coverage after merging issue_128 into issue_116 will be

50.25%

Coverage Report for Changed Files

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
lib/src/core/models
kanji.dart	80%	100%	100%	80%	96
vocabulary.dart	25%	100%	100%	25%	17, 74–75
lib/src/core/utils
kana_utils.dart	100%	100%	100%	100%
lib/src/glossary/widgets
vocabulary_list.dart	75%	100%	100%	75%	45–46, 48–49, 61, 65–66

github-actions[bot] commented 1 month ago

Bump version from 0.28.1+1 to 0.29.0+1

github-actions[bot] commented 1 month ago

Coverage after merging issue_128 into main will be

50.25%

Coverage Report for Changed Files

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
lib/src/core/models
kanji.dart	80%	100%	100%	80%	96
vocabulary.dart	25%	100%	100%	25%	17, 74–75
lib/src/core/utils
kana_utils.dart	100%	100%	100%	100%

github-actions[bot] commented 1 month ago

Coverage after merging issue_128 into main will be

50.25%

Coverage Report for Changed Files

File	Stmts	Branches	Funcs	Lines	Uncovered Lines
lib/src/core/models
kanji.dart	80%	100%	100%	80%	96
vocabulary.dart	25%	100%	100%	25%	17, 74–75
lib/src/core/utils
kana_utils.dart	100%	100%	100%	100%
lib/src/glossary/widgets
vocabulary_list.dart	75%	100%	100%	75%	45–46, 48–49, 61, 65–66

RoadTripMoustache / kana_to_kanji