RoadTripMoustache / kana_to_kanji

Simple application to learn Japanese kana (hiragana, katakana) and kanji
5 stars 1 forks source link

perf(glossary): Improve `KanaList` render performance #254

Closed apomalyn closed 1 month ago

apomalyn commented 1 month ago

๐Ÿ“– Description

Improve the render time of the KanaList by switching GridView.count to builder.

๐Ÿงช How to test the change?

  1. Load the glossary tab
  2. See changes

โ˜‘๏ธ Checklist before requesting a review

github-actions[bot] commented 1 month ago

Bump version from 0.25.1+1 to 0.25.2+1

github-actions[bot] commented 1 month ago

Coverage after merging pref/glossary into main will be

48.42%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/glossary/widgets
   kana_list.dart91.18%100%100%91.18%109, 130, 133, 156, 33–34
github-actions[bot] commented 1 month ago

Bump version from 0.25.5+1 to 0.25.6+1

github-actions[bot] commented 1 month ago

Coverage after merging pref/glossary into main will be

48.42%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/glossary/widgets
   kana_list.dart91.18%100%100%91.18%109, 130, 133, 156, 33–34
github-actions[bot] commented 1 month ago

Bump version from 0.26.0+1 to 0.26.1+1

github-actions[bot] commented 1 month ago

Coverage after merging pref/glossary into main will be

48.42%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/glossary/widgets
   kana_list.dart91.18%100%100%91.18%109, 130, 133, 156, 33–34
github-actions[bot] commented 1 month ago

Bump version from 0.26.1+1 to 0.26.2+1

github-actions[bot] commented 1 month ago

Coverage after merging pref/glossary into main will be

48.42%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/glossary/widgets
   kana_list.dart91.18%100%100%91.18%109, 130, 133, 156, 33–34