RoadTripMoustache / kana_to_kanji

Simple application to learn Japanese kana (hiragana, katakana) and kanji
5 stars 1 forks source link

feat: Implement Landing skeleton #262

Closed Adaendra closed 4 weeks ago

Adaendra commented 1 month ago

Prerequisites

Pull Requests

๐Ÿ“– Description

Implement Landing Skeleton

Note that there's not much design done for the button and the changing text. About the image, it's an incorrect one use because there's no image to use instead for the moment. So I took this one to help me to prepare components.

โ‰๏ธ Related Issues

closes: #132

๐Ÿ–ผ๏ธ Screenshots:

Demo [issue_132.webm](https://github.com/RoadTripMoustache/kana_to_kanji/assets/36586573/d4326aaf-4395-4848-83dd-9e11997e84af)

๐Ÿงช How to test the change?

โ˜‘๏ธ Checklist before requesting a review

github-actions[bot] commented 1 month ago

Coverage after merging issue_132 into issue_135 will be

46.77%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
github-actions[bot] commented 1 month ago

Coverage after merging issue_132 into issue_135 will be

47.22%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
github-actions[bot] commented 1 month ago

Coverage after merging issue_132 into issue_135 will be

48.42%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
github-actions[bot] commented 1 month ago

Coverage after merging issue_132 into issue_135 will be

49.05%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
github-actions[bot] commented 1 month ago

Coverage after merging issue_132 into issue_135 will be

49.05%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
github-actions[bot] commented 1 month ago

Coverage after merging issue_132 into issue_135 will be

49.05%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
github-actions[bot] commented 1 month ago

Coverage after merging issue_132 into issue_135 will be

49.05%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
github-actions[bot] commented 1 month ago

Coverage after merging issue_132 into issue_135 will be

52.51%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
github-actions[bot] commented 1 month ago

Coverage after merging issue_132 into issue_135 will be

52.23%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
github-actions[bot] commented 1 month ago

Bump version from 0.33.0+1 to 0.34.0+1

github-actions[bot] commented 1 month ago

Coverage after merging issue_132 into main will be

52.23%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
github-actions[bot] commented 1 month ago

Bump version from 0.33.2+1 to 0.34.0+1

github-actions[bot] commented 1 month ago

Coverage after merging issue_132 into main will be

52.23%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
apomalyn commented 1 month ago

Here is the latest version with the animation:

Details https://github.com/RoadTripMoustache/kana_to_kanji/assets/22211097/351f21b7-712d-400f-a2fe-37d46f1a6f79

I also cleaned up a little bit the file after putting the animation

github-actions[bot] commented 1 month ago

Coverage after merging issue_132 into main will be

52.23%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
github-actions[bot] commented 1 month ago

Coverage after merging issue_132 into main will be

52.23%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines