Closed Adaendra closed 1 week ago
Coverage after merging issue_134 into issue_132 will be
48.49% |
---|
File | Stmts | Branches | Funcs | Lines | Uncovered Lines |
---|---|---|---|---|---|
lib/src/authentication | |||||
landing_view.dart | 0% | 100% | 100% | 0% | 101, 103–106, 108–110, 113, 115–118, 120, 123–125, 16, 20–21, 29–31, 35, 37–40, 49, 51, 53–55, 57–60, 62, 65, 67, 70, 72, 75–77, 79–80, 85–86, 88–89, 91–92 |
lib/src/authentication/sign_in | |||||
sign_in_view.dart | 93.90% | 100% | 100% | 93.90% | 108–111, 57 |
sign_in_view_model.dart | 62.50% | 100% | 100% | 62.50% | 21, 23, 37, 39, 42, 44 |
Coverage after merging issue_134 into issue_132 will be
49.07% |
---|
File | Stmts | Branches | Funcs | Lines | Uncovered Lines |
---|---|---|---|---|---|
lib/src/authentication | |||||
landing_view.dart | 0% | 100% | 100% | 0% | 101, 103–106, 108–110, 113, 115–118, 120, 123–125, 16, 20–21, 29–31, 35, 37–40, 49, 51, 53–55, 57–60, 62, 65, 67, 70, 72, 75–77, 79–80, 85–86, 88–89, 91–92 |
lib/src/authentication/sign_in | |||||
sign_in_view.dart | 93.90% | 100% | 100% | 93.90% | 108–111, 57 |
sign_in_view_model.dart | 62.50% | 100% | 100% | 62.50% | 21, 23, 37, 39, 42, 44 |
Coverage after merging issue_134 into issue_132 will be
49.05% |
---|
File | Stmts | Branches | Funcs | Lines | Uncovered Lines |
---|---|---|---|---|---|
lib/src/authentication | |||||
landing_view.dart | 0% | 100% | 100% | 0% | 107, 109–111, 113–115, 118, 120–122, 124, 127–129, 16, 20–21, 29–31, 35, 37–40, 43, 45–46, 55, 57, 59–61, 63–66, 68, 71, 73, 76, 78, 81–83, 85–86, 91–92, 94–95, 97–98 |
lib/src/authentication/sign_in | |||||
sign_in_view.dart | 93.90% | 100% | 100% | 93.90% | 108–111, 57 |
sign_in_view_model.dart | 62.50% | 100% | 100% | 62.50% | 21, 23, 37, 39, 42, 44 |
Coverage after merging issue_134 into issue_132 will be
49.47% |
---|
File | Stmts | Branches | Funcs | Lines | Uncovered Lines |
---|---|---|---|---|---|
lib/src/authentication | |||||
landing_view.dart | 0% | 100% | 100% | 0% | 107, 109–111, 113–115, 118, 120–122, 124, 127–129, 16, 20–21, 29–31, 35, 37–40, 43, 45–46, 55, 57, 59–61, 63–66, 68, 71, 73, 76, 78, 81–83, 85–86, 91–92, 94–95, 97–98 |
lib/src/authentication/sign_in | |||||
sign_in_view.dart | 98.18% | 100% | 100% | 98.18% | 59 |
sign_in_view_model.dart | 62.50% | 100% | 100% | 62.50% | 21, 23, 37, 39, 42, 44 |
lib/src/authentication/widgets | |||||
button_apple_logo.dart | 100% | 100% | 100% | 100% | |
button_google_logo.dart | 100% | 100% | 100% | 100% | |
input_email.dart | 100% | 100% | 100% | 100% | |
input_password.dart | 82.61% | 100% | 100% | 82.61% | 46–49 |
Coverage after merging issue_134 into issue_132 will be
52.61% |
---|
File | Stmts | Branches | Funcs | Lines | Uncovered Lines |
---|---|---|---|---|---|
lib/src/authentication | |||||
landing_view.dart | 0% | 100% | 100% | 0% | 107, 109–111, 113–115, 118, 120–122, 124, 127–129, 16, 20–21, 29–31, 35, 37–40, 43, 45–46, 55, 57, 59–61, 63–66, 68, 71, 73, 76, 78, 81–83, 85–86, 91–92, 94–95, 97–98 |
lib/src/authentication/sign_in | |||||
sign_in_view.dart | 98.18% | 100% | 100% | 98.18% | 59 |
sign_in_view_model.dart | 62.50% | 100% | 100% | 62.50% | 21, 23, 37, 39, 42, 44 |
lib/src/authentication/widgets | |||||
button_apple_logo.dart | 100% | 100% | 100% | 100% | |
button_google_logo.dart | 100% | 100% | 100% | 100% | |
input_email.dart | 100% | 100% | 100% | 100% | |
input_password.dart | 82.61% | 100% | 100% | 82.61% | 46–49 |
Coverage after merging issue_134 into issue_132 will be
52.36% |
---|
File | Stmts | Branches | Funcs | Lines | Uncovered Lines |
---|---|---|---|---|---|
lib/src/authentication | |||||
landing_view.dart | 0% | 100% | 100% | 0% | 107, 109–111, 113–115, 118, 120–122, 124, 127–129, 16, 20–21, 29–31, 35, 37–40, 43, 45–46, 55, 57, 59–61, 63–66, 68, 71, 73, 76, 78, 81–83, 85–86, 91–92, 94–95, 97–98 |
lib/src/authentication/sign_in | |||||
sign_in_view.dart | 98.18% | 100% | 100% | 98.18% | 59 |
sign_in_view_model.dart | 62.50% | 100% | 100% | 62.50% | 21, 23, 37, 39, 42, 44 |
lib/src/authentication/widgets | |||||
button_apple_logo.dart | 100% | 100% | 100% | 100% | |
button_google_logo.dart | 100% | 100% | 100% | 100% | |
input_email.dart | 100% | 100% | 100% | 100% | |
input_password.dart | 82.61% | 100% | 100% | 82.61% | 46–49 |
Coverage after merging issue_134 into issue_132 will be
52.36% |
---|
File | Stmts | Branches | Funcs | Lines | Uncovered Lines |
---|---|---|---|---|---|
lib/src/authentication | |||||
landing_view.dart | 0% | 100% | 100% | 0% | 107, 109–111, 113–115, 118, 120–122, 124, 127–129, 16, 20–21, 29–31, 35, 37–40, 43, 45–46, 55, 57, 59–61, 63–66, 68, 71, 73, 76, 78, 81–83, 85–86, 91–92, 94–95, 97–98 |
lib/src/authentication/sign_in | |||||
sign_in_view.dart | 98.18% | 100% | 100% | 98.18% | 59 |
sign_in_view_model.dart | 62.50% | 100% | 100% | 62.50% | 21, 23, 37, 39, 42, 44 |
lib/src/authentication/widgets | |||||
button_apple_logo.dart | 100% | 100% | 100% | 100% | |
button_google_logo.dart | 100% | 100% | 100% | 100% | |
input_email.dart | 100% | 100% | 100% | 100% | |
input_password.dart | 82.61% | 100% | 100% | 82.61% | 46–49 |
Coverage after merging issue_134 into issue_132 will be
52.36% |
---|
File | Stmts | Branches | Funcs | Lines | Uncovered Lines |
---|---|---|---|---|---|
lib/src/authentication | |||||
landing_view.dart | 0% | 100% | 100% | 0% | 107, 109–111, 113–115, 118, 120–122, 124, 127–129, 16, 20–21, 29–31, 35, 37–40, 43, 45–46, 55, 57, 59–61, 63–66, 68, 71, 73, 76, 78, 81–83, 85–86, 91–92, 94–95, 97–98 |
lib/src/authentication/sign_in | |||||
sign_in_view.dart | 98.18% | 100% | 100% | 98.18% | 59 |
sign_in_view_model.dart | 62.50% | 100% | 100% | 62.50% | 21, 23, 37, 39, 42, 44 |
lib/src/authentication/widgets | |||||
button_apple_logo.dart | 100% | 100% | 100% | 100% | |
button_google_logo.dart | 100% | 100% | 100% | 100% | |
input_email.dart | 100% | 100% | 100% | 100% | |
input_password.dart | 82.61% | 100% | 100% | 82.61% | 46–49 |
Coverage after merging issue_134 into issue_132 will be
52.36% |
---|
File | Stmts | Branches | Funcs | Lines | Uncovered Lines |
---|---|---|---|---|---|
lib/src/authentication | |||||
landing_view.dart | 0% | 100% | 100% | 0% | 107, 109–111, 113–115, 118, 120–122, 124, 127–129, 16, 20–21, 29–31, 35, 37–40, 43, 45–46, 55, 57, 59–61, 63–66, 68, 71, 73, 76, 78, 81–83, 85–86, 91–92, 94–95, 97–98 |
lib/src/authentication/sign_in | |||||
sign_in_view.dart | 98.18% | 100% | 100% | 98.18% | 59 |
sign_in_view_model.dart | 62.50% | 100% | 100% | 62.50% | 21, 23, 37, 39, 42, 44 |
lib/src/authentication/widgets | |||||
button_apple_logo.dart | 100% | 100% | 100% | 100% | |
button_google_logo.dart | 100% | 100% | 100% | 100% | |
input_email.dart | 100% | 100% | 100% | 100% | |
input_password.dart | 82.61% | 100% | 100% | 82.61% | 46–49 |
Coverage after merging issue_134 into issue_132 will be
52.51% |
---|
File | Stmts | Branches | Funcs | Lines | Uncovered Lines |
---|---|---|---|---|---|
lib/src/authentication/sign_in | |||||
sign_in_view.dart | 98.18% | 100% | 100% | 98.18% | 59 |
sign_in_view_model.dart | 62.50% | 100% | 100% | 62.50% | 21, 23, 37, 39, 42, 44 |
lib/src/authentication/widgets | |||||
button_apple_logo.dart | 100% | 100% | 100% | 100% | |
button_google_logo.dart | 100% | 100% | 100% | 100% | |
input_email.dart | 100% | 100% | 100% | 100% | |
input_password.dart | 82.61% | 100% | 100% | 82.61% | 46–49 |
Bump version from 0.34.0+1 to 0.35.0+1
Coverage after merging issue_134 into main will be
52.49% |
---|
File | Stmts | Branches | Funcs | Lines | Uncovered Lines |
---|---|---|---|---|---|
lib/src/authentication/sign_in | |||||
sign_in_view.dart | 98.18% | 100% | 100% | 98.18% | 59 |
sign_in_view_model.dart | 60% | 100% | 100% | 60% | 18, 20, 34, 36, 39, 41 |
lib/src/authentication/widgets | |||||
button_apple_logo.dart | 100% | 100% | 100% | 100% | |
button_google_logo.dart | 100% | 100% | 100% | 100% | |
input_email.dart | 100% | 100% | 100% | 100% | |
input_password.dart | 82.61% | 100% | 100% | 82.61% | 46–49 |
The sign in button should be disabled until both email and password are entered. Also, the validation message shouldn't be triggered on all fields when only the first one is triggered
The sign in button should be disabled until both email and password are entered. Also, the validation message shouldn't be triggered on all fields when only the first one is triggered
Pas sûr de comprendre ce que tu veux dire pour l'histoire du message de validation
Bump version from 0.34.0+1 to 0.35.0+1
Coverage after merging issue_134 into main will be
53.11% |
---|
File | Stmts | Branches | Funcs | Lines | Uncovered Lines |
---|---|---|---|---|---|
lib/src/authentication/sign_in | |||||
sign_in_view.dart | 100% | 100% | 100% | 100% | |
sign_in_view_model.dart | 40% | 100% | 100% | 40% | 18, 20, 28–30, 34, 36, 39, 41 |
lib/src/authentication/widgets | |||||
button_logo.dart | 88.89% | 100% | 100% | 88.89% | 8 |
input_email.dart | 100% | 100% | 100% | 100% | |
input_password.dart | 82.61% | 100% | 100% | 82.61% | 47–50 |
Bump version from 0.34.0+1 to 0.35.0+1
Coverage after merging issue_134 into main will be
53.11% |
---|
File | Stmts | Branches | Funcs | Lines | Uncovered Lines |
---|---|---|---|---|---|
lib/src/authentication/sign_in | |||||
sign_in_view.dart | 97.83% | 100% | 100% | 97.83% | 40 |
sign_in_view_model.dart | 40% | 100% | 100% | 40% | 18, 20, 28–30, 34, 36, 39, 41 |
lib/src/authentication/widgets | |||||
button_logo.dart | 88.89% | 100% | 100% | 88.89% | 8 |
input_email.dart | 100% | 100% | 100% | 100% | |
input_password.dart | 82.61% | 100% | 100% | 82.61% | 47–50 |
Coverage after merging issue_134 into main will be
53.11% |
---|
File | Stmts | Branches | Funcs | Lines | Uncovered Lines |
---|---|---|---|---|---|
lib/src/authentication/sign_in | |||||
sign_in_view.dart | 97.83% | 100% | 100% | 97.83% | 40 |
sign_in_view_model.dart | 40% | 100% | 100% | 40% | 18, 20, 28–30, 34, 36, 39, 41 |
lib/src/authentication/widgets | |||||
button_logo.dart | 88.89% | 100% | 100% | 88.89% | 8 |
input_email.dart | 100% | 100% | 100% | 100% | |
input_password.dart | 82.61% | 100% | 100% | 82.61% | 47–50 |
Coverage after merging issue_134 into main will be
54.81% |
---|
File | Stmts | Branches | Funcs | Lines | Uncovered Lines |
---|---|---|---|---|---|
lib/src/authentication/sign_in | |||||
sign_in_view.dart | 95.65% | 100% | 100% | 95.65% | 47, 78–79 |
sign_in_view_model.dart | 86.21% | 100% | 100% | 86.21% | 28, 30–31, 33 |
lib/src/authentication/widgets | |||||
input_email.dart | 100% | 100% | 100% | 100% | |
third_party_round_icon_button.dart | 100% | 100% | 100% | 100% | |
input_password.dart | 100% | 100% | 100% | 100% | |
lib/src/core/widgets | |||||
app_spacer.dart | 63.64% | 100% | 100% | 63.64% | 15, 17, 21, 23 |
Prerequisites
Pull Requests
📖 Description
Create a skeleton for the sign in view with some input validations :
⁉️ Related Issues
closes #134
🖼️ Screenshots:
Demo
[issue_134.webm](https://github.com/RoadTripMoustache/kana_to_kanji/assets/36586573/71a9219e-b216-4d4d-a254-acd7e9798892)🧪 How to test the change?
☑️ Checklist before requesting a review
version: Major
,version: Minor
orversion: Patch
.