RoadTripMoustache / kana_to_kanji

Simple application to learn Japanese kana (hiragana, katakana) and kanji
5 stars 1 forks source link

feat: Sign in skeleton #263

Closed Adaendra closed 1 week ago

Adaendra commented 1 month ago

Prerequisites

Pull Requests

📖 Description

Create a skeleton for the sign in view with some input validations :

⁉️ Related Issues

closes #134

🖼️ Screenshots:

Demo [issue_134.webm](https://github.com/RoadTripMoustache/kana_to_kanji/assets/36586573/71a9219e-b216-4d4d-a254-acd7e9798892)

🧪 How to test the change?

☑️ Checklist before requesting a review

github-actions[bot] commented 1 month ago

Coverage after merging issue_134 into issue_132 will be

48.49%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/authentication
   landing_view.dart0%100%100%0%101, 103–106, 108–110, 113, 115–118, 120, 123–125, 16, 20–21, 29–31, 35, 37–40, 49, 51, 53–55, 57–60, 62, 65, 67, 70, 72, 75–77, 79–80, 85–86, 88–89, 91–92
lib/src/authentication/sign_in
   sign_in_view.dart93.90%100%100%93.90%108–111, 57
   sign_in_view_model.dart62.50%100%100%62.50%21, 23, 37, 39, 42, 44
github-actions[bot] commented 1 month ago

Coverage after merging issue_134 into issue_132 will be

49.07%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/authentication
   landing_view.dart0%100%100%0%101, 103–106, 108–110, 113, 115–118, 120, 123–125, 16, 20–21, 29–31, 35, 37–40, 49, 51, 53–55, 57–60, 62, 65, 67, 70, 72, 75–77, 79–80, 85–86, 88–89, 91–92
lib/src/authentication/sign_in
   sign_in_view.dart93.90%100%100%93.90%108–111, 57
   sign_in_view_model.dart62.50%100%100%62.50%21, 23, 37, 39, 42, 44
github-actions[bot] commented 1 month ago

Coverage after merging issue_134 into issue_132 will be

49.05%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/authentication
   landing_view.dart0%100%100%0%107, 109–111, 113–115, 118, 120–122, 124, 127–129, 16, 20–21, 29–31, 35, 37–40, 43, 45–46, 55, 57, 59–61, 63–66, 68, 71, 73, 76, 78, 81–83, 85–86, 91–92, 94–95, 97–98
lib/src/authentication/sign_in
   sign_in_view.dart93.90%100%100%93.90%108–111, 57
   sign_in_view_model.dart62.50%100%100%62.50%21, 23, 37, 39, 42, 44
github-actions[bot] commented 1 month ago

Coverage after merging issue_134 into issue_132 will be

49.47%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/authentication
   landing_view.dart0%100%100%0%107, 109–111, 113–115, 118, 120–122, 124, 127–129, 16, 20–21, 29–31, 35, 37–40, 43, 45–46, 55, 57, 59–61, 63–66, 68, 71, 73, 76, 78, 81–83, 85–86, 91–92, 94–95, 97–98
lib/src/authentication/sign_in
   sign_in_view.dart98.18%100%100%98.18%59
   sign_in_view_model.dart62.50%100%100%62.50%21, 23, 37, 39, 42, 44
lib/src/authentication/widgets
   button_apple_logo.dart100%100%100%100%
   button_google_logo.dart100%100%100%100%
   input_email.dart100%100%100%100%
   input_password.dart82.61%100%100%82.61%46–49
github-actions[bot] commented 1 month ago

Coverage after merging issue_134 into issue_132 will be

52.61%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/authentication
   landing_view.dart0%100%100%0%107, 109–111, 113–115, 118, 120–122, 124, 127–129, 16, 20–21, 29–31, 35, 37–40, 43, 45–46, 55, 57, 59–61, 63–66, 68, 71, 73, 76, 78, 81–83, 85–86, 91–92, 94–95, 97–98
lib/src/authentication/sign_in
   sign_in_view.dart98.18%100%100%98.18%59
   sign_in_view_model.dart62.50%100%100%62.50%21, 23, 37, 39, 42, 44
lib/src/authentication/widgets
   button_apple_logo.dart100%100%100%100%
   button_google_logo.dart100%100%100%100%
   input_email.dart100%100%100%100%
   input_password.dart82.61%100%100%82.61%46–49
github-actions[bot] commented 1 month ago

Coverage after merging issue_134 into issue_132 will be

52.36%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/authentication
   landing_view.dart0%100%100%0%107, 109–111, 113–115, 118, 120–122, 124, 127–129, 16, 20–21, 29–31, 35, 37–40, 43, 45–46, 55, 57, 59–61, 63–66, 68, 71, 73, 76, 78, 81–83, 85–86, 91–92, 94–95, 97–98
lib/src/authentication/sign_in
   sign_in_view.dart98.18%100%100%98.18%59
   sign_in_view_model.dart62.50%100%100%62.50%21, 23, 37, 39, 42, 44
lib/src/authentication/widgets
   button_apple_logo.dart100%100%100%100%
   button_google_logo.dart100%100%100%100%
   input_email.dart100%100%100%100%
   input_password.dart82.61%100%100%82.61%46–49
github-actions[bot] commented 1 month ago

Coverage after merging issue_134 into issue_132 will be

52.36%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/authentication
   landing_view.dart0%100%100%0%107, 109–111, 113–115, 118, 120–122, 124, 127–129, 16, 20–21, 29–31, 35, 37–40, 43, 45–46, 55, 57, 59–61, 63–66, 68, 71, 73, 76, 78, 81–83, 85–86, 91–92, 94–95, 97–98
lib/src/authentication/sign_in
   sign_in_view.dart98.18%100%100%98.18%59
   sign_in_view_model.dart62.50%100%100%62.50%21, 23, 37, 39, 42, 44
lib/src/authentication/widgets
   button_apple_logo.dart100%100%100%100%
   button_google_logo.dart100%100%100%100%
   input_email.dart100%100%100%100%
   input_password.dart82.61%100%100%82.61%46–49
github-actions[bot] commented 1 month ago

Coverage after merging issue_134 into issue_132 will be

52.36%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/authentication
   landing_view.dart0%100%100%0%107, 109–111, 113–115, 118, 120–122, 124, 127–129, 16, 20–21, 29–31, 35, 37–40, 43, 45–46, 55, 57, 59–61, 63–66, 68, 71, 73, 76, 78, 81–83, 85–86, 91–92, 94–95, 97–98
lib/src/authentication/sign_in
   sign_in_view.dart98.18%100%100%98.18%59
   sign_in_view_model.dart62.50%100%100%62.50%21, 23, 37, 39, 42, 44
lib/src/authentication/widgets
   button_apple_logo.dart100%100%100%100%
   button_google_logo.dart100%100%100%100%
   input_email.dart100%100%100%100%
   input_password.dart82.61%100%100%82.61%46–49
github-actions[bot] commented 1 month ago

Coverage after merging issue_134 into issue_132 will be

52.36%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/authentication
   landing_view.dart0%100%100%0%107, 109–111, 113–115, 118, 120–122, 124, 127–129, 16, 20–21, 29–31, 35, 37–40, 43, 45–46, 55, 57, 59–61, 63–66, 68, 71, 73, 76, 78, 81–83, 85–86, 91–92, 94–95, 97–98
lib/src/authentication/sign_in
   sign_in_view.dart98.18%100%100%98.18%59
   sign_in_view_model.dart62.50%100%100%62.50%21, 23, 37, 39, 42, 44
lib/src/authentication/widgets
   button_apple_logo.dart100%100%100%100%
   button_google_logo.dart100%100%100%100%
   input_email.dart100%100%100%100%
   input_password.dart82.61%100%100%82.61%46–49
github-actions[bot] commented 1 month ago

Coverage after merging issue_134 into issue_132 will be

52.51%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/authentication/sign_in
   sign_in_view.dart98.18%100%100%98.18%59
   sign_in_view_model.dart62.50%100%100%62.50%21, 23, 37, 39, 42, 44
lib/src/authentication/widgets
   button_apple_logo.dart100%100%100%100%
   button_google_logo.dart100%100%100%100%
   input_email.dart100%100%100%100%
   input_password.dart82.61%100%100%82.61%46–49
github-actions[bot] commented 4 weeks ago

Bump version from 0.34.0+1 to 0.35.0+1

github-actions[bot] commented 4 weeks ago

Coverage after merging issue_134 into main will be

52.49%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/authentication/sign_in
   sign_in_view.dart98.18%100%100%98.18%59
   sign_in_view_model.dart60%100%100%60%18, 20, 34, 36, 39, 41
lib/src/authentication/widgets
   button_apple_logo.dart100%100%100%100%
   button_google_logo.dart100%100%100%100%
   input_email.dart100%100%100%100%
   input_password.dart82.61%100%100%82.61%46–49
apomalyn commented 3 weeks ago

The sign in button should be disabled until both email and password are entered. Also, the validation message shouldn't be triggered on all fields when only the first one is triggered

Adaendra commented 3 weeks ago

The sign in button should be disabled until both email and password are entered. Also, the validation message shouldn't be triggered on all fields when only the first one is triggered

Pas sûr de comprendre ce que tu veux dire pour l'histoire du message de validation

github-actions[bot] commented 3 weeks ago

Bump version from 0.34.0+1 to 0.35.0+1

github-actions[bot] commented 3 weeks ago

Coverage after merging issue_134 into main will be

53.11%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/authentication/sign_in
   sign_in_view.dart100%100%100%100%
   sign_in_view_model.dart40%100%100%40%18, 20, 28–30, 34, 36, 39, 41
lib/src/authentication/widgets
   button_logo.dart88.89%100%100%88.89%8
   input_email.dart100%100%100%100%
   input_password.dart82.61%100%100%82.61%47–50
github-actions[bot] commented 3 weeks ago

Bump version from 0.34.0+1 to 0.35.0+1

github-actions[bot] commented 3 weeks ago

Coverage after merging issue_134 into main will be

53.11%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/authentication/sign_in
   sign_in_view.dart97.83%100%100%97.83%40
   sign_in_view_model.dart40%100%100%40%18, 20, 28–30, 34, 36, 39, 41
lib/src/authentication/widgets
   button_logo.dart88.89%100%100%88.89%8
   input_email.dart100%100%100%100%
   input_password.dart82.61%100%100%82.61%47–50
github-actions[bot] commented 2 weeks ago

Coverage after merging issue_134 into main will be

53.11%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/authentication/sign_in
   sign_in_view.dart97.83%100%100%97.83%40
   sign_in_view_model.dart40%100%100%40%18, 20, 28–30, 34, 36, 39, 41
lib/src/authentication/widgets
   button_logo.dart88.89%100%100%88.89%8
   input_email.dart100%100%100%100%
   input_password.dart82.61%100%100%82.61%47–50
github-actions[bot] commented 1 week ago

Coverage after merging issue_134 into main will be

54.81%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/authentication/sign_in
   sign_in_view.dart95.65%100%100%95.65%47, 78–79
   sign_in_view_model.dart86.21%100%100%86.21%28, 30–31, 33
lib/src/authentication/widgets
   input_email.dart100%100%100%100%
   third_party_round_icon_button.dart100%100%100%100%
   input_password.dart100%100%100%100%
lib/src/core/widgets
   app_spacer.dart63.64%100%100%63.64%15, 17, 21, 23