RoadTripMoustache / kana_to_kanji

Simple application to learn Japanese kana (hiragana, katakana) and kanji
5 stars 1 forks source link

feat: Link account skeleton #264

Open Adaendra opened 1 month ago

Adaendra commented 1 month ago

Prerequisites

Pull Requests

📖 Description

Create a skeleton page for the account creation.

⁉️ Related Issues

closes #133

🖼️ Screenshots:

Demo [issue_133.webm](https://github.com/RoadTripMoustache/kana_to_kanji/assets/36586573/f1fa228e-3d39-47fb-97a2-8697f64a8387)
Example screen for IOS ![image](https://github.com/RoadTripMoustache/kana_to_kanji/assets/36586573/3e57105e-fe6d-452f-bfe0-9c53fbadd2cb)

🧪 How to test the change?

☑️ Checklist before requesting a review

github-actions[bot] commented 1 month ago

Coverage after merging issue_133 into issue_134 will be

50.22%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/authentication
   landing_view.dart0%100%100%0%102, 104–107, 109–111, 114, 116–119, 121, 124–126, 17, 21–22, 30–32, 36, 38–41, 50, 52, 54–56, 58–61, 63, 66, 68, 71, 73, 76–78, 80–81, 86–87, 89–90, 92–93
lib/src/authentication/create
   create_account_view.dart89.58%100%100%89.58%110–113, 150–154, 59
   create_account_view_model.dart75%100%100%75%36, 38, 41, 43
github-actions[bot] commented 1 month ago

Coverage after merging issue_133 into issue_134 will be

50.77%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/authentication
   landing_view.dart0%100%100%0%102, 104–107, 109–111, 114, 116–119, 121, 124–126, 17, 21–22, 30–32, 36, 38–41, 50, 52, 54–56, 58–61, 63, 66, 68, 71, 73, 76–78, 80–81, 86–87, 89–90, 92–93
lib/src/authentication/create
   create_account_view.dart89.58%100%100%89.58%110–113, 150–154, 59
   create_account_view_model.dart75%100%100%75%36, 38, 41, 43
github-actions[bot] commented 1 month ago

Coverage after merging issue_133 into issue_134 will be

50.77%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/authentication/create
   create_account_view.dart89.58%100%100%89.58%110–113, 150–154, 59
   create_account_view_model.dart75%100%100%75%36, 38, 41, 43
github-actions[bot] commented 1 month ago

Coverage after merging issue_133 into issue_134 will be

50.77%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/authentication/create
   create_account_view.dart89.58%100%100%89.58%110–113, 150–154, 59
   create_account_view_model.dart75%100%100%75%36, 38, 41, 43
github-actions[bot] commented 1 month ago

Coverage after merging issue_133 into issue_134 will be

51.14%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/authentication/create
   create_account_view.dart89.58%100%100%89.58%110–113, 150–154, 59
   create_account_view_model.dart75%100%100%75%36, 38, 41, 43
github-actions[bot] commented 1 month ago

Coverage after merging issue_133 into issue_134 will be

50.83%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/authentication/create
   create_account_view.dart98.11%100%100%98.11%61
   create_account_view_model.dart75%100%100%75%36, 38, 41, 43
lib/src/authentication/widgets
   input_password.dart87.50%100%100%87.50%62–65
github-actions[bot] commented 1 month ago

Coverage after merging issue_133 into issue_134 will be

53.88%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/authentication/create
   create_account_view.dart98.11%100%100%98.11%61
   create_account_view_model.dart75%100%100%75%36, 38, 41, 43
lib/src/authentication/widgets
   input_password.dart87.50%100%100%87.50%62–65
github-actions[bot] commented 1 month ago

Coverage after merging issue_133 into issue_134 will be

53.62%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/authentication/create
   create_account_view.dart98.11%100%100%98.11%61
   create_account_view_model.dart75%100%100%75%36, 38, 41, 43
lib/src/authentication/widgets
   input_password.dart87.50%100%100%87.50%62–65
github-actions[bot] commented 1 month ago

Coverage after merging issue_133 into issue_134 will be

53.62%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/authentication/create
   create_account_view.dart98.11%100%100%98.11%61
   create_account_view_model.dart75%100%100%75%36, 38, 41, 43
lib/src/authentication/widgets
   input_password.dart87.50%100%100%87.50%62–65
github-actions[bot] commented 1 month ago

Coverage after merging issue_133 into issue_134 will be

53.62%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/authentication/create
   create_account_view.dart98.11%100%100%98.11%61
   create_account_view_model.dart75%100%100%75%36, 38, 41, 43
lib/src/authentication/widgets
   input_password.dart87.50%100%100%87.50%62–65
github-actions[bot] commented 1 month ago

Coverage after merging issue_133 into issue_134 will be

53.77%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/authentication/create
   create_account_view.dart98.11%100%100%98.11%61
   create_account_view_model.dart75%100%100%75%36, 38, 41, 43
lib/src/authentication/widgets
   input_password.dart87.50%100%100%87.50%62–65
github-actions[bot] commented 4 weeks ago

Coverage after merging issue_133 into issue_134 will be

53.75%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/authentication/create
   create_account_view.dart98.11%100%100%98.11%61
   create_account_view_model.dart75%100%100%75%36, 38, 41, 43
lib/src/authentication/widgets
   input_password.dart87.50%100%100%87.50%62–65
github-actions[bot] commented 3 weeks ago

Coverage after merging issue_133 into issue_134 will be

54.21%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/authentication/create
   create_account_view.dart100%100%100%100%
   create_account_view_model.dart75%100%100%75%36, 38, 41, 43
lib/src/authentication/widgets
   input_password.dart87.50%100%100%87.50%63–66
github-actions[bot] commented 3 weeks ago

Coverage after merging issue_133 into issue_134 will be

54.20%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/authentication/create
   create_account_view.dart97.67%100%100%97.67%40
   create_account_view_model.dart75%100%100%75%36, 38, 41, 43
lib/src/authentication/widgets
   input_password.dart87.50%100%100%87.50%63–66
github-actions[bot] commented 2 weeks ago

Coverage after merging issue_133 into issue_134 will be

54.20%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/authentication/create
   create_account_view.dart97.67%100%100%97.67%40
   create_account_view_model.dart75%100%100%75%36, 38, 41, 43
lib/src/authentication/widgets
   input_password.dart87.50%100%100%87.50%63–66
Adaendra commented 4 days ago

Notes vis à vis des changements : TextInputAction.continueAction doit être changé car non supporté sur Android

github-actions[bot] commented 4 days ago

Bump version from 0.35.1+1 to 0.36.0+1

github-actions[bot] commented 4 days ago

Coverage after merging issue_133 into main will be

55.93%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/authentication/create
   create_account_view.dart97.67%100%100%97.67%40
   create_account_view_model.dart75%100%100%75%36, 38, 41, 43
lib/src/authentication/widgets
   input_email.dart100%100%100%100%
   input_password.dart100%100%100%100%
   button_logo.dart88.89%100%100%88.89%8
github-actions[bot] commented 3 days ago

Coverage after merging issue_133 into main will be

55.92%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/authentication/create
   create_account_view.dart90.32%100%100%90.32%41, 64–65, 72–73, 76
   create_account_view_model.dart69.23%100%100%69.23%34, 36–37, 39, 52, 54, 57, 59
lib/src/authentication/widgets
   input_email.dart100%100%100%100%
   input_password.dart97.83%100%100%97.83%78
github-actions[bot] commented 2 days ago

Coverage after merging issue_133 into main will be

55.98%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/authentication/create
   create_account_view.dart93.44%100%100%93.44%41, 71–72, 75
   create_account_view_model.dart69.23%100%100%69.23%34, 36–37, 39, 52, 54, 57, 59
lib/src/authentication/widgets
   input_email.dart100%100%100%100%
   input_password.dart97.83%100%100%97.83%78
github-actions[bot] commented 2 days ago

Coverage after merging issue_133 into main will be

56.06%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/authentication/create
   create_account_view.dart93.65%100%100%93.65%39, 78–79, 83
   create_account_view_model.dart72.22%100%100%72.22%34, 36–37, 39, 60–61, 63, 66–67, 69
lib/src/authentication/sign_in
   sign_in_view.dart95.71%100%100%95.71%47, 78–79
lib/src/authentication/widgets
   input_email.dart100%100%100%100%
   input_password.dart100%100%100%100%
github-actions[bot] commented 1 day ago

Coverage after merging issue_133 into main will be

56.04%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/authentication/create
   create_account_view.dart93.55%100%100%93.55%39, 77–78, 82
   create_account_view_model.dart72.22%100%100%72.22%34, 36–37, 39, 60–61, 63, 66–67, 69
lib/src/authentication/widgets
   input_email.dart100%100%100%100%
   input_password.dart100%100%100%100%