RoadTripMoustache / kana_to_kanji

Simple application to learn Japanese kana (hiragana, katakana) and kanji
5 stars 1 forks source link

feat: Link account banner #280

Open Adaendra opened 1 month ago

Adaendra commented 1 month ago

Prerequisites

Pull Requests

📖 Description

Add the link account banner and process to link account.

⁉️ Related Issues

closes: #146 #138

🖼️ Screenshots:

Demo [issue_146.webm](https://github.com/RoadTripMoustache/kana_to_kanji/assets/36586573/911af698-1d56-4463-8382-e4ad69195754)

🧪 How to test the change?

☑️ Checklist before requesting a review

github-actions[bot] commented 1 month ago

Coverage after merging issue_146 into issue_145 will be

52.74%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/authentication/create
   create_account_view.dart98.11%100%100%98.11%60
   create_account_view_model.dart71.43%100%100%71.43%43–45, 48–50
lib/src/authentication/services
   auth_service.dart0%100%100%0%106–107, 113, 116, 121–122, 125–126, 134–135, 141–142, 145, 147–154, 156, 160, 164–169, 17, 170–176, 18, 180, 182, 24, 26–29, 37, 40, 44, 47–49, 53–56, 60, 63, 67, 70–72, 76–80, 88, 93–94, 97–98
lib/src/authentication/utils
   crypto_utils.dart0%100%100%0%5–8
lib/src/core/dataloaders
   user_dataloader.dart0%100%100%0%16–17, 19, 24–25, 28–31
lib/src/core/models
   api_user.dart25%100%100%25%53–54, 56
lib/src/core/repositories
   user_repository.dart73.33%100%100%73.33%101, 114, 127–128, 131–132, 24, 26–28, 31–32
lib/src/core/services
   api_service.dart0%100%100%0%15–17, 26–28
   token_service.dart50%100%100%50%19–20, 23
   user_service.dart0%100%100%0%12–13, 15, 19–20, 23, 25, 29–30
lib/src/profile
   profile_view_model.dart81.82%100%100%81.82%17, 42
   profile_view.dart0%100%100%0%15, 17, 19–20, 22–25, 28–29, 31–36, 39, 41, 44, 46–47, 50–52, 54
lib/src/profile/widgets
   link_account_banner.dart86.67%100%100%86.67%26–27
github-actions[bot] commented 1 month ago

Coverage after merging issue_146 into issue_145 will be

52.96%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/authentication/create
   create_account_view.dart98.11%100%100%98.11%60
   create_account_view_model.dart71.43%100%100%71.43%43–45, 48–50
lib/src/authentication/services
   auth_service.dart0%100%100%0%106–107, 113, 116, 121–122, 125–126, 134–135, 141–142, 145, 147–154, 156, 160, 164–169, 17, 170–176, 18, 180, 182, 24, 26–29, 37, 40, 44, 47–49, 53–56, 60, 63, 67, 70–72, 76–80, 88, 93–94, 97–98
lib/src/authentication/utils
   crypto_utils.dart0%100%100%0%5–8
lib/src/core/dataloaders
   user_dataloader.dart0%100%100%0%16–17, 19, 24–25, 28–31
lib/src/core/models
   api_user.dart25%100%100%25%53–54, 56
lib/src/core/repositories
   user_repository.dart73.33%100%100%73.33%101, 114, 127–128, 131–132, 24, 26–28, 31–32
lib/src/core/services
   api_service.dart0%100%100%0%15–17, 26–28
   token_service.dart50%100%100%50%19–20, 23
   user_service.dart0%100%100%0%12–13, 15, 19–20, 23, 25, 29–30
lib/src/profile
   profile_view_model.dart81.82%100%100%81.82%17, 42
   profile_view.dart0%100%100%0%15, 17, 19–20, 22–25, 28–29, 31–36, 39, 41, 44, 46–47, 50–52, 54
lib/src/profile/widgets
   link_account_banner.dart86.67%100%100%86.67%26–27
github-actions[bot] commented 4 weeks ago

Coverage after merging issue_146 into issue_145 will be

52.95%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/authentication/create
   create_account_view.dart98.11%100%100%98.11%60
   create_account_view_model.dart71.43%100%100%71.43%43–45, 48–50
lib/src/authentication/services
   auth_service.dart0%100%100%0%106–107, 113, 116, 121–122, 125–126, 134–135, 141–142, 145, 147–154, 156, 160, 164–169, 17, 170–176, 18, 180, 182, 24, 26–29, 37, 40, 44, 47–49, 53–56, 60, 63, 67, 70–72, 76–80, 88, 93–94, 97–98
lib/src/authentication/utils
   crypto_utils.dart0%100%100%0%5–8
lib/src/core/dataloaders
   user_dataloader.dart0%100%100%0%16–17, 19, 24–25, 28–31
lib/src/core/models
   api_user.dart25%100%100%25%53–54, 56
lib/src/core/repositories
   user_repository.dart73.33%100%100%73.33%101, 114, 127–128, 131–132, 24, 26–28, 31–32
lib/src/core/services
   api_service.dart0%100%100%0%15–17, 26–28
   token_service.dart50%100%100%50%19–20, 23
   user_service.dart0%100%100%0%12–13, 15, 19–20, 23, 25, 29–30
lib/src/profile
   profile_view_model.dart81.82%100%100%81.82%17, 42
   profile_view.dart0%100%100%0%15, 17, 19–20, 22–25, 28–29, 31–36, 39, 41, 44, 46–47, 50–52, 54
lib/src/profile/widgets
   link_account_banner.dart86.67%100%100%86.67%26–27
Adaendra commented 3 weeks ago

@apomalyn à noter que la partie sur l'updateSelf a été changé dans la PR #282 pour correspondre à ce que tu vises

github-actions[bot] commented 3 weeks ago

Coverage after merging issue_146 into issue_145 will be

53.45%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/authentication/create
   create_account_view_model.dart71.43%100%100%71.43%43–45, 48–50
lib/src/authentication/services
   auth_service.dart0%100%100%0%106–107, 113, 116, 121–122, 125–126, 134–135, 141–142, 145, 147–154, 156, 160, 164–169, 17, 170–176, 18, 180, 182, 24, 26–29, 37, 40, 44, 47–49, 53–56, 60, 63, 67, 70–72, 76–80, 88, 93–94, 97–98
lib/src/authentication/utils
   crypto_utils.dart0%100%100%0%5–8
lib/src/core/dataloaders
   user_dataloader.dart0%100%100%0%16–17, 19, 24–25, 28–31
lib/src/core/models
   api_user.dart25%100%100%25%53–54, 56
lib/src/core/repositories
   user_repository.dart73.33%100%100%73.33%101, 114, 127–128, 131–132, 24, 26–28, 31–32
lib/src/core/services
   api_service.dart0%100%100%0%15–17, 26–28
   token_service.dart50%100%100%50%19–20, 23
   user_service.dart0%100%100%0%12–13, 15, 19–20, 23, 25, 29–30
lib/src/profile
   profile_view_model.dart81.82%100%100%81.82%17, 42
   profile_view.dart0%100%100%0%15, 17, 19–20, 22–25, 28–29, 31–36, 39, 41, 44, 46–47, 50–52, 54
lib/src/profile/widgets
   link_account_banner.dart86.67%100%100%86.67%26–27
github-actions[bot] commented 3 weeks ago

Coverage after merging issue_146 into issue_145 will be

53.44%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/authentication/create
   create_account_view_model.dart71.43%100%100%71.43%43–45, 48–50
lib/src/authentication/services
   auth_service.dart0%100%100%0%106–107, 113, 116, 121–122, 125–126, 134–135, 141–142, 145, 147–154, 156, 160, 164–169, 17, 170–176, 18, 180, 182, 24, 26–29, 37, 40, 44, 47–49, 53–56, 60, 63, 67, 70–72, 76–80, 88, 93–94, 97–98
lib/src/authentication/utils
   crypto_utils.dart0%100%100%0%5–8
lib/src/core/dataloaders
   user_dataloader.dart0%100%100%0%16–17, 19, 24–25, 28–31
lib/src/core/models
   api_user.dart25%100%100%25%53–54, 56
lib/src/core/repositories
   user_repository.dart73.33%100%100%73.33%101, 114, 127–128, 131–132, 24, 26–28, 31–32
lib/src/core/services
   api_service.dart0%100%100%0%15–17, 26–28
   token_service.dart50%100%100%50%19–20, 23
   user_service.dart0%100%100%0%12–13, 15, 19–20, 23, 25, 29–30
lib/src/profile
   profile_view_model.dart81.82%100%100%81.82%17, 42
   profile_view.dart0%100%100%0%15, 17, 19–20, 22–25, 28–29, 31–36, 39, 41, 44, 46–47, 50–52, 54
lib/src/profile/widgets
   link_account_banner.dart86.67%100%100%86.67%26–27
github-actions[bot] commented 3 weeks ago

Coverage after merging issue_146 into issue_145 will be

52.50%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/authentication/create
   create_account_view_model.dart71.43%100%100%71.43%43–45, 48–50
lib/src/authentication/services
   auth_service.dart0%100%100%0%106–107, 113, 116, 121–122, 125–126, 134–135, 141–142, 145, 147–154, 156, 160, 164–169, 17, 170–176, 18, 180, 182, 24, 26–29, 37, 40, 44, 47–49, 53–56, 60, 63, 67, 70–72, 76–80, 88, 93–94, 97–98
lib/src/authentication/utils
   crypto_utils.dart0%100%100%0%5–8
lib/src/core/dataloaders
   user_dataloader.dart0%100%100%0%16–17, 19, 24–25, 28–31
lib/src/core/models
   api_user.dart25%100%100%25%53–54, 56
lib/src/core/repositories
   user_repository.dart73.33%100%100%73.33%101, 114, 127–128, 131–132, 24, 26–28, 31–32
lib/src/core/services
   api_service.dart0%100%100%0%15–17, 26–28
   token_service.dart50%100%100%50%19–20, 23
   user_service.dart0%100%100%0%12–13, 15, 19–20, 23, 25, 29–30
lib/src/profile
   profile_view_model.dart81.82%100%100%81.82%17, 42
   profile_view.dart0%100%100%0%15, 17, 19–20, 22–25, 28–29, 31–36, 39, 41, 44, 46–47, 50–52, 54
lib/src/profile/widgets
   link_account_banner.dart86.67%100%100%86.67%26–27
github-actions[bot] commented 2 weeks ago

Coverage after merging issue_146 into issue_145 will be

52.50%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src/authentication/create
   create_account_view_model.dart71.43%100%100%71.43%43–45, 48–50
lib/src/authentication/services
   auth_service.dart0%100%100%0%106–107, 113, 116, 121–122, 125–126, 134–135, 141–142, 145, 147–154, 156, 160, 164–169, 17, 170–176, 18, 180, 182, 24, 26–29, 37, 40, 44, 47–49, 53–56, 60, 63, 67, 70–72, 76–80, 88, 93–94, 97–98
lib/src/authentication/utils
   crypto_utils.dart0%100%100%0%5–8
lib/src/core/dataloaders
   user_dataloader.dart0%100%100%0%16–17, 19, 24–25, 28–31
lib/src/core/models
   api_user.dart25%100%100%25%53–54, 56
lib/src/core/repositories
   user_repository.dart73.33%100%100%73.33%101, 114, 127–128, 131–132, 24, 26–28, 31–32
lib/src/core/services
   api_service.dart0%100%100%0%15–17, 26–28
   token_service.dart50%100%100%50%19–20, 23
   user_service.dart0%100%100%0%12–13, 15, 19–20, 23, 25, 29–30
lib/src/profile
   profile_view_model.dart81.82%100%100%81.82%17, 42
   profile_view.dart0%100%100%0%15, 17, 19–20, 22–25, 28–29, 31–36, 39, 41, 44, 46–47, 50–52, 54
lib/src/profile/widgets
   link_account_banner.dart86.67%100%100%86.67%26–27