search

RoadTripMoustache / kana_to_kanji

Simple application to learn Japanese kana (hiragana, katakana) and kanji
5 stars 1 forks source link

feat(feedback): Implement feedback feature! (#28) #91

Closed apomalyn closed 11 months ago

apomalyn commented 11 months ago

📖 Description

Implementation of feedback option. This option can be found under the General section of the settings. It will open a bottom sheet with the option to create a feature request or report a bug. It will then ask the user to give more information on the feedback he/she wants to offer, and finally, create a GitHub issue on this repository

The user also has the option to take a screenshot of the application using the Feedback.

Rules applied on the feedback form

Other changes

⁉️ Related Issues

closes #28

🖼️ Screenshots:

Demonstration 'Feature request' on iOS, the issue created --> #89 https://github.com/RoadTripMoustache/kana_to_kanji/assets/22211097/84b213e6-73cd-4b7a-a44f-cb154f161604
Demonstration 'Report bug' on iOS, the issue created --> #90 https://github.com/RoadTripMoustache/kana_to_kanji/assets/22211097/1aa402c1-6199-4b12-a7c2-27b0e95aa9ec

The Android build looks the same, except for one detail. On the screenshot screen, the Report button is more prominent, I try to find a solution without success.

🧪 How to test the change?

  1. If you are testing locally, make sure to update your .env, run flutter clean and regenerate the files
  2. Go to the Settings view
  3. Click on Give feedback button
  4. See changes

☑️ Checklist before requesting a review

github-actions[bot] commented 11 months ago

Bump version from 0.8.0+1 to 0.9.0+1

github-actions[bot] commented 11 months ago

Coverage after merging feat/28 into main will be

63.04%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src
   locator.dart3.45%100%100%3.45%20–21, 24–29, 34–35, 38, 40–41, 50–56, 59–61, 63–66, 68
lib/src/core/constants
   app_theme.dart80%100%100%80%5
   app_configuration.dart0%100%100%0%28
   regexp.dart100%100%100%100%
lib/src/core/services
   dialog_service.dart0%100%100%0%26–27, 29–30, 7
   info_service.dart0%100%100%0%24–26, 28–30, 33, 35–37, 39–40, 43–44, 49–51, 54, 56–57, 60–62, 65, 67–68, 71, 73, 76, 78–79
lib/src/core/utils
   extensions.dart15.38%100%100%15.38%11–21
lib/src/feedback
   feedback_view.dart4.76%100%100%4.76%14, 16–21, 23–24, 26–35, 39
   feedback_view_model.dart75%100%100%75%142–143, 40–45, 47–50, 60, 70
lib/src/feedback/service
   github_service.dart0%100%100%0%17–19, 24, 26–29, 31–33, 35–36, 40, 43, 45–46, 48, 50, 52–53, 57–60
lib/src/feedback/utils
   build_issue_helper.dart100%100%100%100%
lib/src/feedback/widgets
   draggable_sheet_feedback.dart0%100%100%0%10–11, 14, 16–22, 6, 8
   feedback_form.dart98.44%100%100%98.44%144
   feedback_type_selection.dart100%100%100%100%
   feedback_success_dialog.dart100%100%100%100%
   feedback_screenshot_form.dart95.65%100%100%95.65%45
lib/src/settings
   settings_view_model.dart72.73%100%100%72.73%37, 50–51, 54–55, 60
lib/src/settings/widgets
   button_item.dart100%100%100%100%
github-actions[bot] commented 11 months ago

Coverage after merging feat/28 into main will be

63.04%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src
   locator.dart3.45%100%100%3.45%20–21, 24–29, 34–35, 38, 40–41, 50–56, 59–61, 63–66, 68
lib/src/core/constants
   app_theme.dart80%100%100%80%5
   app_configuration.dart0%100%100%0%28
   regexp.dart100%100%100%100%
lib/src/core/services
   dialog_service.dart0%100%100%0%26–27, 29–30, 7
   info_service.dart0%100%100%0%24–26, 28–30, 33, 35–37, 39–40, 43–44, 49–51, 54, 56–57, 60–62, 65, 67–68, 71, 73, 76, 78–79
lib/src/core/utils
   extensions.dart15.38%100%100%15.38%11–21
lib/src/feedback
   feedback_view.dart4.76%100%100%4.76%14, 16–21, 23–24, 26–35, 39
   feedback_view_model.dart75%100%100%75%142–143, 40–45, 47–50, 60, 70
lib/src/feedback/service
   github_service.dart0%100%100%0%17–19, 24, 26–29, 31–33, 35–36, 40, 43, 45–46, 48, 50, 52–53, 57–60
lib/src/feedback/utils
   build_issue_helper.dart100%100%100%100%
lib/src/feedback/widgets
   draggable_sheet_feedback.dart0%100%100%0%10–11, 14, 16–22, 6, 8
   feedback_form.dart98.44%100%100%98.44%144
   feedback_type_selection.dart100%100%100%100%
   feedback_success_dialog.dart100%100%100%100%
   feedback_screenshot_form.dart95.65%100%100%95.65%45
lib/src/settings
   settings_view_model.dart72.73%100%100%72.73%37, 50–51, 54–55, 60
lib/src/settings/widgets
   button_item.dart100%100%100%100%
github-actions[bot] commented 11 months ago

Coverage after merging feat/28 into main will be

63.74%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src
   locator.dart3.45%100%100%3.45%20–21, 24–29, 34–35, 38, 40–41, 50–56, 59–61, 63–66, 68
lib/src/core/constants
   app_theme.dart80%100%100%80%5
   app_configuration.dart0%100%100%0%28
   regexp.dart100%100%100%100%
lib/src/core/services
   dialog_service.dart0%100%100%0%26–27, 29–30, 7
   info_service.dart0%100%100%0%24–26, 28–30, 33, 35–37, 39–40, 43–44, 49–51, 54, 56–57, 60–62, 65, 67–68, 71, 73, 76, 78–79
lib/src/core/utils
   extensions.dart15.38%100%100%15.38%11–21
lib/src/feedback
   feedback_view.dart4.76%100%100%4.76%14, 16–21, 23–24, 26–35, 39
   feedback_view_model.dart75%100%100%75%142–143, 40–45, 47–50, 60, 70
lib/src/feedback/service
   github_service.dart0%100%100%0%17–19, 24, 26–29, 31–33, 35–36, 40, 43, 45–46, 48, 50, 52–53, 57–60
lib/src/feedback/utils
   build_issue_helper.dart100%100%100%100%
lib/src/feedback/widgets
   draggable_sheet_feedback.dart0%100%100%0%10–11, 14, 16–22, 6, 8
   feedback_form.dart98.44%100%100%98.44%144
   feedback_type_selection.dart100%100%100%100%
   feedback_success_dialog.dart100%100%100%100%
   feedback_screenshot_form.dart95.65%100%100%95.65%45
lib/src/settings
   settings_view_model.dart95.45%100%100%95.45%60
lib/src/settings/widgets
   button_item.dart100%100%100%100%
github-actions[bot] commented 11 months ago

Coverage after merging feat/28 into main will be

64.43%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src
   locator.dart3.45%100%100%3.45%20–21, 24–29, 34–35, 38, 40–41, 50–56, 59–61, 63–66, 68
lib/src/core/constants
   app_theme.dart80%100%100%80%5
   app_configuration.dart0%100%100%0%28
   regexp.dart100%100%100%100%
lib/src/core/services
   dialog_service.dart0%100%100%0%26–27, 29–30, 7
   info_service.dart0%100%100%0%24–26, 28–30, 33, 35–37, 39–40, 43–44, 49–51, 54, 56–57, 60–62, 65, 67–68, 71, 73, 76, 78–79
lib/src/core/utils
   extensions.dart15.38%100%100%15.38%11–21
lib/src/feedback
   feedback_view.dart4.76%100%100%4.76%14, 16–21, 23–24, 26–35, 39
   feedback_view_model.dart85.45%100%100%85.45%171–172, 59–62, 72, 84
lib/src/feedback/service
   github_service.dart0%100%100%0%17–19, 24, 26–29, 31–33, 35–36, 40, 45, 47–48, 50, 52, 54–55, 59–62
lib/src/feedback/utils
   build_issue_helper.dart100%100%100%100%
lib/src/feedback/widgets
   draggable_sheet_feedback.dart0%100%100%0%10–11, 17, 20–26, 6, 8
   feedback_form.dart98.39%100%100%98.39%145
   feedback_type_selection.dart100%100%100%100%
   feedback_success_dialog.dart100%100%100%100%
   feedback_screenshot_form.dart95.65%100%100%95.65%46
lib/src/settings
   settings_view_model.dart95.45%100%100%95.45%61
lib/src/settings/widgets
   button_item.dart100%100%100%100%
github-actions[bot] commented 11 months ago

Coverage after merging feat/28 into main will be

65.43%

Coverage Report for Changed Files
FileStmtsBranchesFuncsLinesUncovered Lines
lib/src
   locator.dart3.45%100%100%3.45%20–21, 24–29, 34–35, 38, 40–41, 50–56, 59–61, 63–66, 68
lib/src/core/constants
   app_theme.dart80%100%100%80%5
   app_configuration.dart0%100%100%0%28
   regexp.dart100%100%100%100%
lib/src/core/services
   dialog_service.dart0%100%100%0%26–27, 29–30, 7
   info_service.dart0%100%100%0%24–26, 28–30, 33, 35–37, 39–40, 43–44, 49–51, 54, 56–57, 60–62, 65, 67–68, 71, 73, 76, 78–79
lib/src/feedback
   feedback_view.dart4.76%100%100%4.76%14, 16–21, 23–24, 26–35, 39
   feedback_view_model.dart85.45%100%100%85.45%171–172, 59–62, 72, 84
lib/src/feedback/service
   github_service.dart0%100%100%0%17–19, 24, 26–29, 31–33, 35–36, 40, 45, 47–48, 50, 52, 54–55, 59–62
lib/src/feedback/utils
   build_issue_helper.dart100%100%100%100%
lib/src/feedback/widgets
   draggable_sheet_feedback.dart0%100%100%0%10–11, 17, 20–26, 6, 8
   feedback_form.dart98.39%100%100%98.39%145
   feedback_type_selection.dart100%100%100%100%
   feedback_success_dialog.dart100%100%100%100%
   feedback_screenshot_form.dart95.65%100%100%95.65%46
lib/src/settings
   settings_view_model.dart95.45%100%100%95.45%61
lib/src/settings/widgets
   button_item.dart100%100%100%100%