RobLoach / drush-docker

:whale: Docker Container to run Drush
http://registry.hub.docker.com/u/drush/drush
Other
19 stars 19 forks source link

PHP 7.1 #50

Closed adamstrawson closed 1 year ago

adamstrawson commented 6 years ago

I noticed there's a php7.1 composer container in the works, are there any plans to carry that up to drush-docker?

I'd love to use this container, but we're not able to while it's running 7.0. as our Drupal environments use 7.1

Doing so gives me the below error as the void return type was added in PHP 7.1. Doctrine uses the void return type but PHP seems to look for the type in the Doctrine namespace where it can't be found.

For now we've created our own image based of the composer:php7.1.4-alpine Dockerfile so that it's running 7.1


Fatal error: Uncaught TypeError: Return value of Doctrine\Common\Annotations\AnnotationRegistry::reset() must be an instance of Doctrine\Common\Annotations\void, none returned in /app/vendor/doctrine/annotations/lib/Doctrine/Common/Annotations/AnnotationRegistry.php:55
Stack trace:
#0 /app/core/lib/Drupal/Component/Annotation/Plugin/Discovery/AnnotatedClassDiscovery.php(113): Doctrine\Common\Annotations\AnnotationRegistry::reset()
#1 /app/core/lib/Drupal/Core/Entity/EntityTypeManager.php(106): Drupal\Component\Annotation\Plugin\Discovery\AnnotatedClassDiscovery->getDefinitions()
#2 /app/core/lib/Drupal/Core/Plugin/DefaultPluginManager.php(174): Drupal\Core\Entity\EntityTypeManager->findDefinitions()
#3 /app/core/lib/Drupal/Component/Plugin/Discovery/DiscoveryCachedTrait.php(22): Drupal\Core\Plugin\DefaultPluginManager->getDefinitions()
#4 /app/core/lib/Drupal/Core/Entity/EntityTypeManager.php(126): Drupal\Core\Plugin\DefaultPluginManager->getDefinition('block', false)
#5 /app/core/lib/Drupal/Core/Entity/EntityTypeManager. in /app/vendor/doctrine/annotations/lib/Doctrine/Common/Annotations/AnnotationRegistry.php on line 55
Drush command terminated abnormally due to an unrecoverable error.       [error]```