rewrite and append with full file context

Robitx / gp.nvim

Gp.nvim (GPT prompt) Neovim AI plugin: ChatGPT sessions & Instructable text/code operations & Speech to text [OpenAI, Ollama, Anthropic, ..]

MIT License

784 stars 67 forks source link

rewrite and append with full file context #142

Open tommyengstrom opened 3 months ago

tommyengstrom commented 3 months ago

This adds support for including the whole file in addition to the selected text in rewrite and append selection.

I don't expect this to be merged as is. Mostly wanted to ask if you'd like to add this if I clean it up a bit. Let me know what you think.

quolpr commented 3 months ago

@Robitx this looks awesome, could you merge?

tommyengstrom commented 3 months ago

hehe. yeah, this is not intended as a final PR, just checking if there's interest.

Should I go ahead an clean it up a bit? I.e. mostly doing what @quolpr suggested.

1orZero commented 3 months ago

Definitely interested! Thank you for creating this PR!

Looks like there are conflicts to be resolved.

gonzaloserrano commented 3 months ago

+1 interested in this, and @quolpr suggestions such as extracting the 4o model change to a new PR.

tommyengstrom commented 2 months ago

@Robitx Any thoughts on this?

Robitx commented 2 months ago

@tommyengstrom Hey, sorry for not looking into it sooner.

Yes this is heading in a good direction, but I would like to prevent combinatorial explosion for commands based on the context, there are many possible contexts people might want to use:

no context
.gp.md repo instructions
current file
all visible buffers
all open buffers
context build from LSP/Treesitter analysis
...

So I would go in the direction of a separate set of commands similar to https://github.com/Robitx/gp.nvim?tab=readme-ov-file#agent-commands for switching the type of context which will be used by the commands such as GpRewrite.

tommyengstrom commented 2 months ago

I suspect most of those examples are not really going to be used, thus making the "combinatorial explosion of commands" a non issue. I considered adding LSP output in this command but haven't done so. If done I don't see a point in having a separate command without it.

Either way, I'm not interested in spending time on implementing that.

alivault commented 1 month ago

I would also be interested in having the option to include the current file as context for visual append and rewrite commands.