fix: fix parameters and clean up node handles

RobotWebTools / web_video_server

HTTP Streaming of ROS Image Topics in Multiple Formats

http://ros.org/wiki/web_video_server

Other

269 stars 187 forks source link

Open DerKurt opened 1 year ago

DerKurt commented 1 year ago

Public API Changes None

Description Parameters where not usable before. private_nh isn't needed.

DerKurt commented 1 year ago

See issue #137

styczen commented 3 months ago

@rctoris Do we know why this PR is not merged? This fix is quite helpful.

DerKurt commented 3 weeks ago

@chameau5050 I don´t have access to the branch anymore, but I notified some people that have and hopefully they can do the changes.

chameau5050 commented 3 weeks ago

@arneboe also add this code after this line and compile issue should be fix for humble and above :

if("$ENV{ROS_DISTRO}" STREQUAL "humble")
 target_compile_definitions(${PROJECT_NAME} PRIVATE USE_CV_BRIDGE_H)
endif()