Closed jabailey closed 6 years ago
@jabailey Please say, after your fix this bug your videostreaming (with codec vp8) has big latency or not?? Can show it(in youtube or anywhere )?
Patch looks good to me. could you create a PR to patch this?
@SystemDiagnosticss Yes, I've found that there is high latency - the stream takes about 5-10 seconds to initialize, and the frames play 5-10 seconds behind. I don't see how my change could affect that, but I'll admit I'm not very familiar with this code. Is the latency lower without my change?
I saw the high latency too with codec vp8. @randoms do you have any idea?
@jabailey @jihoonl In case mjpeg stream I have 2-3 sec latency. But its very very big latency. I am new in ROS but situation with videostream is very funny for me. I work with videostream without ROS (Raspberry Pi to web page) and has latency 0.2 sec. Its uv4l libs for videostream. https://www.linux-projects.org/uv4l/tutorials/ This project use webrtc. I try use webrts for ROS (http://wiki.ros.org/webrtc_ros) but I can't install it. I create questions on rosanswer, stackoverflow but not receive an answer. I don't understand is it really in ROS does not have good videostreaming solution ?? This is very strange
To reproduce: run
web_video_server
like normal, then point browser tohttp://localhost:8080/stream_viewer?topic=/some/unpublished/topic&type=vp8
Results:
The segfault seems to stem from referencing
format_context_
in theLibavStreamer
destructor before it's been allocated: https://github.com/RobotWebTools/web_video_server/blob/develop/src/libav_streamer.cpp#L80Quick fix (tested on a local branch):