solve DOMException (cross origin) Error when using point cloud in ros3djs from depthcloud_encoder mjpeg encoder.

RobotWebTools / web_video_server

HTTP Streaming of ROS Image Topics in Multiple Formats

http://ros.org/wiki/web_video_server

Other

270 stars 188 forks source link

solve DOMException (cross origin) Error when using point cloud in ros3djs from depthcloud_encoder mjpeg encoder. #92

Closed oka1125 closed 4 years ago

oka1125 commented 5 years ago

In order to solve 'DOMException (cross origin) Error when using point cloud in ros3djs from depthcloud_encoder mjpeg encoder', I edited web_video_server package's multipart_stream.cpp and added 'Access-Control-' tags. Then, DOMException(cross-origin) no longer occured in ros3d.js.

related issues:

DepthCloud streaming format error 173
- https://github.com/RobotWebTools/ros3djs/issues/173
DOMException (cross origin) Error when using point cloud in ros3djs from depthcloud_encoder mjpeg encoder. #91

oka1125 commented 5 years ago

How can I make review request? ("Reviewers" in side bar is not selectable.)

jihoonl commented 5 years ago

@oka1125 sorry for late review.

@mvollrath Would you help me to review this? I am not very familiar with cross origin in web server. I am wondering if allowing headers and methods is ok for security.

mvollrath commented 4 years ago

It should be pointed out that this server is insecure by default, so I wouldn't recommend publishing it to the internet. Because * is allowed, anybody can embed your video stream anywhere. You probably don't want your video stream on somebody else's hacked index page.

jihoonl commented 4 years ago

Ok. Thanks @mvollrath @oka1125