Decouple driver - Githubissues

alvarovillena commented 2 years ago

Decouple python library and ROS package to make them independent and ease library updates.
Publish cell_voltages to debug and identify cell issues from ROS. This requires an updated version of robotnik_msgs/BatteryStatus message, which is introduced in commit ba65e127. Please merge the related PR 4 in robotnik_msgs before merging this one.

alvarovillena commented 2 years ago

By the way, this should not be a fork from the driver anymore

alvarovillena commented 2 years ago

Fixed several issues related to time_remaining calculation that caused either division by 0 or trying to publish a negative number in an unsigned int message. This was causing either constant publications with the same values without crashing, or node crashing.

Also fixed the fact that we were not taking into account the mosfet 'stationary' mode. Time charging and charging status was not being updated in this case. If node was initialized when mosfet was in 'stationary' mode, we were not reporting charge.

RobotnikAutomation / daly_bms

Decouple driver #1