RocketChat / Rocket.Chat

The communications platform that puts data protection first.
https://rocket.chat/
Other
40.32k stars 10.46k forks source link

Where is Audio & Video call Button ? #9632

Closed RiusmaX closed 5 years ago

RiusmaX commented 6 years ago

Description:

I've installed a fresh instance of Rocket.Chat 0.61 on Ubuntu 16.04 with snapd and when i'm in a private chat with someone, I can't see the "Call Button" for start an audio or a video call anywhere (WebRTC is set).

Server Setup Information:

Steps to Reproduce:

  1. Run a VM with Ubuntu 16.04
  2. Run in a terminal "sudo snap install rocketchat-server"
  3. Go to http://:3000
  4. Create an account
  5. Ask a Friend or take a second device to create a second account
  6. Try to launch a call

Expected behavior:

The buttons "Call" is displayed in the user section.

Actual behavior:

Impossible to find the button anywhere. I can only use the Jitsi call feature.

rasos commented 6 years ago

Check if WebRTC is activated https://yourdomain.net/admin/WebRTC duplicate of RocketChat/Rocket.Chat#9632 ?

ElieMyIdea commented 6 years ago

+1 Duplicated by itself 😋 ? Like said before, WebRTC is enable in admin Panel with default parameters set ;)

Please need some help 🙏

afroDC commented 6 years ago

We're also experiencing the same issue.

LifeIsAParadox commented 6 years ago

same.

xenithorb commented 6 years ago

This should be probably retitled:

"WebRTC Administration options left behind after feature removal"

Nevermind that, I read something wrong

der-eismann commented 6 years ago

I just noticed that I can start audio & video calls, but only in private rooms & open channels. In direct messages the option is missing.

xenithorb commented 6 years ago

@der-eismann That sounds more like the meet.jit.si integration?

Does the button say "Video Chat?", if so that's the jitsi integration.

The symptom of this bug for me is that if I disable that functionality from the admin panel via Administration -> Video Conference - Enabled: False then the menu for any conversation whether private, direct, or public looks like so:

image

The point being, that this is with Administration -> WebRTC -> Enabled For *: True

der-eismann commented 6 years ago

No, I have jitsi and video conferences disabled and enabled WebRTC everywhere. But the audio & video calls are still missing from direct messages. This is the user information in a room or channel: rocket channel And this is in direct messages: rocket dm

xenithorb commented 6 years ago

Indeed, I found it too:

screenshot

Man that's in a really unintuitive spot.

xenithorb commented 6 years ago

Also, It's true that User<->User rooms don't have this... And to make things work the icon is overloaded:

image

Contrast that with the previous behavior:

image

karlprieb commented 6 years ago

Hey guys, thank you all for your reports!

@arthurgiustina will work on a better way to display this options (icons + label, or just icons, idk) and I will investigate that to make it work again!

arthurgiustina commented 6 years ago

user information

@karlprieb check this idea =)

xenithorb commented 6 years ago

I really like that, including how the mute icon is clearer about its intentions. Well done.

Phuzzy112 commented 6 years ago

Hi all, I'm about 90% done with putting RC into prod here, but am getting pressured about this. Any ETA that I could pass along?

PS love that mockup

versavius commented 6 years ago

Also in the drop down menu next to a user in the attached screenshot we have the "Video Chat" button if this was changed to two buttons "Audio Call" and "Video Call" as well as arthurgiustina suggestion that would make it so much easier to make audio/video calls.

image

graywolf336 commented 6 years ago

@karlprieb when you guys go to do this, please add these convert this pull request to the new style: https://github.com/RocketChat/Rocket.Chat/pull/3635

avignat commented 6 years ago

Please bring those buttons back. I'm also affected running Rocket 0.65.0 with WebRTC enable for MP, private and public groups.

reetp commented 6 years ago

I only use video/audio when in Direct Messages, and the person I do use video with mainly is hardly ever in the private group, which means I now have to scroll back to find their last comment in the group to start a call. Frustrating and wastes time.

jrichard8 commented 6 years ago

Version 0.64.2

WebRTC activated and dont have button to launch voice call. Whats wrong ?

agustinventura commented 6 years ago

Hi guys, this was scheduled for 0.65, is there any new milestone planned for the release?

tonylemeunier commented 6 years ago

Hi team,

First great job with this app. I installed 0.65.1 and buttons are still missing.

Best Regards,

flantascience commented 6 years ago

So am I to understand correctly... that th enew approach to doing a 'group' video call in a channel is to use Jitsi? Or is there also a regular WebRTC approach?

I feel like every public channel use to have an option to just enable an Audio call or a Video call and the little boxes with people's videos would show up. Now, it seems we've got to use Jitsi? I don't have a big problem with that.

I guess my main goal is to not necessarily do a group video chat BUT to be able to livestream my screen to a large group of people at once. Is that possible using this feature? To have more of a one-way call, without everyone having to be on a video. Just a one-to-many approach?

xenithorb commented 6 years ago

In my experience it was just easier to have people go to a meet.jit.si link (and it has gotten really good at screensharing on both chromium and firefox lately.)

What I liked the WebRTC feature for was 1-1 calling. It worked well for quick chats

flantascience commented 6 years ago

What if my goal is to have my screen be shared for group viewing but everyone else be watching it and chatting in the rocket.chat message area. Not to have everyone on a video chat together? Kinda like running a webinar

reetp commented 6 years ago

We only used video for 1 to 1 and miss this a lot.

Not keen on being forced to use external services (GDPR & all that jazz)

agustinventura commented 6 years ago

@xenithorb that's exactly our use case, we just want WebRTC calls for 1-1 calling. Besides we can't use jitsi for some weird network reasons :)

HammyHavoc commented 6 years ago

Going to have to agree with @reetp; Nextcloud is offering a completely self-hosted chat, voice and video platform that ties in with their file system. Seems like an odd move for RocketChat to not support WebRTC anymore and to favour Jitsi of all things.

daradurvs commented 6 years ago

I vote for the following features:

darnux commented 6 years ago

Whats the current situation regarding this topic? I am running the lastest release and have Rocket.Chat WebRTC enabled but I am not able to start a private video chat.

ealbers commented 6 years ago

I also would like to know when this will be implemented. We are stuck on a previous release until this feature is added back to the current set.

MisterJD commented 6 years ago

Im was so happy about that to find a really good self hosted alternative to slack or discord for my team. Its very sad that an audio call or video call feature is currently missing (Jitsi is not an option for us).

Hope for any updates on this topic in the near future.

reetp commented 6 years ago

Are any of the devs actually looking at this?

Now on 0.69.1 and you still can't start a call via a Direct Message despite the option still being there in Admin/WebRTC.

That's more than 6 months after this was reported as an issue and you said you would be looking at it.

If you want to drop Web RTC directly in favour of Jitsi (a bad move IMHO for those with privacy concerns) then fine, just make the decision and get on with it.

But leaving this just lying around untouched and uncared for is not great PR.

ealbers commented 6 years ago

I agree with reetp

ealbers commented 6 years ago

I applied your fix and that worked! Thank you so much!

real19 commented 6 years ago

When are you guys planning to add all these calling features to mobile?

real19 commented 6 years ago

I am a mobile developer and I would like to add them too..

danpospisil commented 6 years ago

Any update? We need this too.

Shaverdoff commented 6 years ago

0/70/0 still only public and private room video&audio call in webrtc even in Admin panel "Enable for Direct Messages" set true. pleeease... return that features

pwittke commented 5 years ago

any news when PR https://github.com/RocketChat/Rocket.Chat/pull/11962 will be implemented ? This issue exists for 9 months and @vkislichenko added a fix on Sep 5th. For 3 Update Versions this issue is ignored. We are holding back updates in order to keep this feature for our users. :(

naroga commented 5 years ago

For those still missing the buttons to start video calls, for me the fix was to go on https:///admin/Video%2520Conference and enable it.

Shaverdoff commented 5 years ago

that is not fix.. whole radio button is enable but no webrtc by direct.

jeffreyvanbarneveld commented 5 years ago

Is this gonna be solved?

Shaverdoff commented 5 years ago

Nope. Still no any progress

Отправлено с iPhone

6 дек. 2018 г., в 22:15, Jeffrey van Barneveld notifications@github.com<mailto:notifications@github.com> написал(а):

Is this gonna be solved?

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/RocketChat/Rocket.Chat/issues/9632#issuecomment-444973569, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ApxoJnk7TV4wVwaRkLAGT2-GAdUIO3UYks5u2V6dgaJpZM4R9YQ2.

qwrty-ftw commented 5 years ago

Any news ?

tassoevan commented 5 years ago

The whole bunch of WebRTC support relied over the deprecated URL.createObjectURL() API which was removed for Google Chrome 71. AFAIK some browser-specific bugs and changes in the front-end team contributed for the postponing too. I'm still checking the amount of rework required to get this feature back on track.

Shaverdoff commented 5 years ago

So not all users netsurfing on Gh, some of them use ff;) like me:) This is only opinion, no claims

-- Gerasim Shaverdov | Deputy CTO | Altarix Mobile: +7 937 070 66 84<tel:+7%20937%20070%2066%2084> | Skype/email: gerasim@altarix.rumailto:gerasim@altarix.ru Lenina av.25, Samara, Russia, 443068

28 дек. 2018 г., в 17:13, Tasso Evangelista notifications@github.com<mailto:notifications@github.com> написал(а):

The whole bunch of WebRTC support relied over the deprecated URL.createObjectURL() API which was removed for Google Chrome 71. AFAIK some browser-specific bugs and changes in the front-end team contributed for the postponing too. I'm still checking the amount of rework required to get this feature back on track.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/RocketChat/Rocket.Chat/issues/9632#issuecomment-450357382, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ApxoJnMJbHdcWJpivAXBe-jzYf0_-Bzbks5u9hkDgaJpZM4R9YQ2.

pwittke commented 5 years ago

Any News?

9joshua commented 5 years ago

I have a WebRTC phone system using Twilio. It still works with Chrome 71+. Also, as @Shaverdoff mentioned, using FF should still work. Perhaps only show the call button if browser type = FF? At any rate, this is a very essential part of RC and we are coming up on one year since this issue was lodged.

Shaverdoff commented 5 years ago

in last FF there are no call button on dm. only strange block. in desktop electron client to - no call button.

9joshua commented 5 years ago

Hmm, I think you are right @Shaverdoff. I have an old RC 54 installation and the button is still there (for Chrome and FF) but once the other party accepts the call, there is no conversation status indicator and the call does not connect.