Runix-Minecraft / Runix

Home of the forge based, Runecraft inspired Minecraft mod
3 stars 0 forks source link

fix the rune system #11

Closed 0xilly closed 10 years ago

0xilly commented 10 years ago

Rune system broke due to the loss of block ids and the moving of some forge events to FML

josiahseaman commented 10 years ago

the title is an incredibly vague. Could you be more specific in what is broken? I do have some notes on rune orientation for you.

rivkiinshadows commented 10 years ago

I can answer that. All runes are not able to function due to the loss of id's in Forge (aka. no more Block.waterStill or 9 or Block.waterStill.blockID), so we have to come up with a new system to fix the issue.

0xilly commented 10 years ago

Sorry about the vagueness I was using that to remind me of what needs to be done

josiahseaman commented 10 years ago

alright well all of the rune patterns reference Constants that are defined in abstract rune. That means that you can just change in there and then change the variable type and the rest of the code can remain unmodified. (For some strange reason I can't delete text to fix my typos)

0xilly commented 10 years ago

While the old system was nice, for the sake of an API and to make it easier to give Blocks/Items energy values for future updates the system is getting a overhaul closing this as fix the rune system has turned into a rewrite. See https://github.com/Runix-Minecraft/Runix/blob/1.7/common/com/newlinegaming/runix/api/RunixAPI.java