search

Runix-Minecraft / Runix

Home of the forge based, Runecraft inspired Minecraft mod
3 stars 0 forks source link

Runes persist in Single Player client between world saves #44

Closed Amuxix closed 10 years ago

Amuxix commented 10 years ago

I found out a bug that makes teleports move the player to the wrong position, here is how to reproduce it.

  1. Create a single player world.
  2. Create a waypoint.
  3. Create a new single player world.
  4. Create a waypoint with the same signature as the previous world.
  5. Teleport to that signature.

You get teleported to the coordinates of the waypoint of the first world.

josiahseaman commented 10 years ago

That is a really nicely done Issue. LordIllyohs is happy you confirmed something he thought maybe might be happening. We'll look into this ASAP.

josiahseaman commented 10 years ago

This is a perfect example of why having detailed steps to reproduce an issue is so important. Thank you Amuxix. This turned out to be a much more interesting issue than it originally looked like. What's happening actually doesn't have anything to do with Waypoints, signature, or save file locations. Runes are all loaded into RAM whenever you open up a world with Runes in it. When you exit that world, they stay in RAM when you're in the main menu. Then, when you open up a new world, the new world begins running with all the runes that are already there.

I was able to partially disable this behavior by clearing the activeMagic() list. This will prevent them from migrating into the world save JSONs. So that's a partial win. What was more difficult was unregistering Runes from the event handlers. This is still an issue for Torch Bearer and Zeerix Chest.