Rutherther / NosSmooth

Nostale bot library written in C#. May describe the current state of the game/character from packets. Multiple sources available for capturing the packets from running game.
MIT License
6 stars 3 forks source link

Add missing fields to PtctlPacket #71

Closed plsfixrito closed 1 year ago

Rutherther commented 1 year ago

I think it looks similar to end of walk packets, it's likely speed of the entity. Not always 9, changes for different mates

Rutherther commented 1 year ago

It looks to me that the speed is not sent from the server. It probably has to be obtained from nostale data files, from IInfoService.GetMonsterInfoAsync

plsfixrito commented 1 year ago

I think it looks similar to end of walk packets, it's likely speed of the entity. Not always 9, changes for different mates

I renamed the fields to their names.

It looks to me that the speed is not sent from the server. It probably has to be obtained from nostale data files, from IInfoService.GetMonsterInfoAsync

The speed property type is inconsistent is the project. In packets sometimes defined as byte other times as short and in ILivingEntity it is an integer. I think all speed properties should use the same type.

Rutherther commented 1 year ago

You are absolutely right, I think there are more inconsistencies like that. Sadly I did not manage to make it consistent yet even though I wanted.