Open marcellourbani opened 3 years ago
IObert
commented
3 years ago In general: Yes, everything that has "ABAP" in the name probably qualifies :)
Feel free to open a PR that adds your npm packages and github repo.
The VS Code Extension items would also be great. But for this, I (or someone else) would need to add a new provider that uses an official API from the VS Code Marketplace. Is there such an API that also provides the download count?
marcellourbani
commented
3 years ago Yes there's an api Will look into it when I have time
On Wed, 25 Aug 2021, 17:19 Marius Obert, @.***> wrote:
In general: Yes, everything that has "ABAP" in the name probably qualifies :)
Feel free to open a PR that adds your npm packages and github repo.
The VS Code Extension items would also be great. But for this, I (or someone else) would need to add a new provider that uses an official API from the VS Code Marketplace. Is there such an API that also provides the download count?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/SAP-samples/artifact-of-the-month/issues/3#issuecomment-905681421, or unsubscribe https://github.com/notifications/unsubscribe-auth/AASW6HMVRQ7ZFRRVK5FAJADT6UJXPANCNFSM5CZCHRUA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .
IObert
commented
3 years ago I added some of the items that you mentioned above (besides the VS Code Marketplace thing)
marianfoo
commented
2 years ago @marcellourbani what API do you mean? There is a non-documented API? https://github.com/microsoft/vscode/issues/31168 But even with that, downloads are not included. There is always scraping, but i don´t think Marius would like that :D
marcellourbani
commented
2 years ago try this:
curl 'https://marketplace.visualstudio.com/_apis/public/gallery/extensionquery' -H 'content-type: application/json' \
--data-raw '{"filters":[{"criteria":[{"filterType":8,"value":"Microsoft.VisualStudio.Code"},{"filterType":10,"value":"abap"},{"filterType":12,"value":"4096"}],"pageNumber":1,"pageSize":50,"sortBy":0,"sortOrder":0}],"assetTypes":[],"flags":950}' \
--compressed\
|jq '.results[].extensions[]|{displayName,installs:.statistics[] | select(.statisticName == "install").value}'Yeah, works well but is it officially allowed? Apparently it's more of a grey area. Marius would have to decide, but would be great to use it.
curl --location --request POST 'https://marketplace.visualstudio.com/_apis/public/gallery/extensionquery' \
--header 'Accept: application/json;api-version=3.0-preview.1' \
--header 'Content-Type: application/json' \
--data-raw '{
"filters": [
{
"criteria": [
{
"filterType": 7,
"value": "larshp.vscode-abap"
},
{
"filterType": 12,
"value": "4096"
}
],
"pageNumber": 1,
"pageSize": 50,
"sortBy": 0,
"sortOrder": 0
}
],
"assetTypes": [],
"flags": 950
}'Result:
marcellourbani
commented
2 years ago No idea, I just replicated the call vscode does. There should be some documentation somewhere as openvsix has a similar one, and you can replace it in vscode.
Now, since this is:
one can legitimately assume it is, but it's not rock solid. Probably opening a vscode issue is the only way to be sure
IObert
commented
2 years ago I'm afraid these points don't make it a public API as there is not real documentation for it. I think we need to keep this item on hold until there is a definite page that explains the usage.
Is this supposed to cover external stuff like my vscode plugin, AbapPretty and abap_test_runner_cli? AbapLint? Libraries like abap-adt-api?