SAP-samples / artifact-of-the-month

A SAPUI5 application that ranks the popularity of SAP packages and repositories from multiple platforms. The usage data is pulled periodically from these platforms by GitHub Actions. The web app itself is hosted via GitHub Pages.
https://sap-samples.github.io/artifact-of-the-month/
Apache License 2.0
9 stars 9 forks source link

fix Highlight formatter when no description available #4

Closed marianfoo closed 3 years ago

marianfoo commented 3 years ago

Reproduce the problem: Go to the 'all' page Use the search here and type 'ui5'. Expand results and try to show results 75-100 Since the artifact has no description, an error is thrown in the 'formatHighlight' method in the formatter that was not caught.

Suggested solution: Check if 'string' value is 'null'.

CLAassistant commented 3 years ago

CLA assistant check
All committers have signed the CLA.

IObert commented 3 years ago

Oh, wow. This is a stupid bug from my side 🙈 Many thanks for finding and fixing it!

marianfoo commented 3 years ago

@IObert no worries, you´re welcome 😀