search

SAP-samples / artifact-of-the-month

A SAPUI5 application that ranks the popularity of SAP packages and repositories from multiple platforms. The usage data is pulled periodically from these platforms by GitHub Actions. The web app itself is hosted via GitHub Pages.
https://sap-samples.github.io/artifact-of-the-month/
Apache License 2.0
9 stars 9 forks source link

remove growing attributes from list #8

Closed marianfoo closed 2 years ago

marianfoo commented 2 years ago

Error: You call up the page https://sap-samples.github.io/artifact-of-the-month/ and filter for "Code Repositories". However, no repositories are displayed although there are two available in the top 99.

Cause: Since the 'growing' attribute is used in the list control, only the first 25 entries are loaded. Only these are filtered for ''Repos''. In this case, the repo on position 37 and 81 is not displayed.

Suggested solution: Remove the 'growing' parameter in the views 'new', 'trends' and 'updated'. Since there are only 99 entries in these views anyway, the performance decrease is minimal. The view 'all' is not affected by this, because there is a different filter process.

IObert commented 2 years ago

I've noticed this behavior recently as well but wanted to check if there's a neat way to have the best of both worlds (growing list and working filters). But I couldn't find a solution yet, so I guess your PR is the best way to deal with this for now.

Thanks :)