Closed AlapanGhosh closed 2 years ago
btw, just for an info, latest version pf pyodata wil have fix for DateTimeOffset - relevant to timezones. Our odata services (sap gateway) returns everything in UTC, so far it was not a problem.
But worth looking into the timezone part in generator.py - as separate issue, since depends on version bump.
btw, just for an info, latest version pf pyodata wil have fix for DateTimeOffset - relevant to timezones. Our odata services (sap gateway) returns everything in UTC, so far it was not a problem.
But worth looking into the timezone part in generator.py - as separate issue, since depends on version bump.
@phanak-sap from what I understood, the timezone details would be a separate property of the DateTimeOffset object with the new update. Since we are generating the timezone offset in generator itself, I dont think this adds a constraint on ODFuzz.
Merging #110 (b8ce4d8) into master (b11aab0) will decrease coverage by
0.24%
. The diff coverage is25.71%
.
@@ Coverage Diff @@
## master #110 +/- ##
==========================================
- Coverage 62.17% 61.92% -0.25%
==========================================
Files 19 19
Lines 3630 3651 +21
==========================================
+ Hits 2257 2261 +4
- Misses 1373 1390 +17
Impacted Files | Coverage Δ | |
---|---|---|
odfuzz/generators.py | 65.38% <25.71%> (-4.57%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update ca29196...b8ce4d8. Read the comment docs.
Is this ready for review or still a Draft?
Looks good, thx for the fix.
Added support to switch between generic and SAP OData implementation for the EDMtype DateTimeOffset.
This is an extension to #106
Further reading: https://blogs.sap.com/2017/01/05/date-and-time-in-sap-gateway-foundation/