SAP / odfuzz

Apache License 2.0
18 stars 12 forks source link

Added support SAP_VENDOR_ENABLED for DateTimeOffset #110

Closed AlapanGhosh closed 2 years ago

AlapanGhosh commented 2 years ago

Added support to switch between generic and SAP OData implementation for the EDMtype DateTimeOffset.

This is an extension to #106

Further reading: https://blogs.sap.com/2017/01/05/date-and-time-in-sap-gateway-foundation/

phanak-sap commented 2 years ago

btw, just for an info, latest version pf pyodata wil have fix for DateTimeOffset - relevant to timezones. Our odata services (sap gateway) returns everything in UTC, so far it was not a problem.

But worth looking into the timezone part in generator.py - as separate issue, since depends on version bump.

https://github.com/SAP/python-pyodata/pull/184

AlapanGhosh commented 2 years ago

btw, just for an info, latest version pf pyodata wil have fix for DateTimeOffset - relevant to timezones. Our odata services (sap gateway) returns everything in UTC, so far it was not a problem.

But worth looking into the timezone part in generator.py - as separate issue, since depends on version bump.

SAP/python-pyodata#184

@phanak-sap from what I understood, the timezone details would be a separate property of the DateTimeOffset object with the new update. Since we are generating the timezone offset in generator itself, I dont think this adds a constraint on ODFuzz.

codecov-commenter commented 2 years ago

Codecov Report

Merging #110 (b8ce4d8) into master (b11aab0) will decrease coverage by 0.24%. The diff coverage is 25.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #110      +/-   ##
==========================================
- Coverage   62.17%   61.92%   -0.25%     
==========================================
  Files          19       19              
  Lines        3630     3651      +21     
==========================================
+ Hits         2257     2261       +4     
- Misses       1373     1390      +17     
Impacted Files Coverage Δ
odfuzz/generators.py 65.38% <25.71%> (-4.57%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ca29196...b8ce4d8. Read the comment docs.

phanak-sap commented 2 years ago

Is this ready for review or still a Draft?

phanak-sap commented 2 years ago

Looks good, thx for the fix.