search

SGA-A / c2c

Source code for the custom app exclusive to cc, where most interactions begin and end.
MIT License
1 stars 0 forks source link

Rewrite and removal of slays #74

Closed SGA-A closed 6 months ago

SGA-A commented 7 months ago

Describe the bug The problem here is that each time when you change what servant you are viewing, you are constructing another instance of the client. This causes interactions to become much slower than usual.

This is sometimes very slow and often leads to the interaction failing to respond within 3 seconds. As a result, we've had to defer every single response to the callback within the select menu. This is not ideal but it is 'the best option' currently. This issue addresses the need to rewrite this entirely. It is not an effective way of fetching the servants and could easily be improved.

To Reproduce Steps to reproduce the behavior of the bot not responding:

  1. Use /servants lookup
  2. Click another option within the select menu (meaning the servants owned by a user is more than 1)
  3. Bot sometimes fails to respond within 3 seconds causing the Unknown Interaction error.

Expected behavior Responding to the interaction quickly with no errors.

Additional context When the bot does not to respond to an interaction within 3 seconds, the interaction fails. If you want to allow it to respond within an extended timeframe, you need to defer the response using a webhook.

SGA-A commented 7 months ago

This is at the near bottom of our to-do list because we have other larger things planned for the bot. If we had to guess when this issue is to be addressed, it'd be within 3-4 months, though that's based on the assumption we have a lot of free time in the summer (unlikely).

Edit: We are considering working on this earlier than anticipated.

SGA-A commented 6 months ago

We have decided that we will leave the system as it is. The feature is more or less abandoned at this point due to its isolated nature in the economy.

We have other plans for the bot, which until they are met, this system will not be receiving much attention. It will unfortunatley stay this way for a while. Worst case scenario is that it's removed entirely if outdated/not aligned with our goals.