search

SGA-A / c2c

Source code for the custom app exclusive to cc, where most interactions begin and end.
MIT License
2 stars 0 forks source link

Investigate unclosed aiohttp sessions #93

Closed SGA-A closed 1 month ago

SGA-A commented 2 months ago

Describe the bug Unclosed sessions and response handlers seem to occur. Context managers are the solution. The unclosed response handler seems to be coming from the waifu.im http client.

SGA-A commented 2 months ago

This issue has been resolved.

SGA-A commented 2 months ago

This issue seems to occur yet again, except in very rare cases. We are reopening the issue, and will continue to monitor the possible cause through iterative testing.

SGA-A commented 2 months ago

As expected, there have been no signs whatsoever of a unclosed session ever since the issue was reopened. This issue will remain open indefinitley until we identify the root cause of it. It won't be easy though due to the lack of cues as for what could be the cause. Since it only mentions the session object location in memory, we don't know what could be causing it. Our only choice is to guess, and by delving deep into how we use our client sessions.

SGA-A commented 1 month ago

Closing the issue now as its been a full week of triaging through what the cause possible could be, and there have been no warnings of an unclosed session/response handler ever since.