search

SIMKL / script.simkl

Kodi add-on for Simkl
https://simkl.com/apps/kodi/
GNU General Public License v3.0
40 stars 14 forks source link

Scrobbles on Start when video hasn't loaded #31

Closed AzzieDev closed 6 years ago

AzzieDev commented 6 years ago

This issue isn't easy to reproduce so I will just explain the problem and what can possibly be done to fix it:

Problem: Occasionally, if a video is opened, it might scrobble instantly when it starts playing. This is because the video hasn't "loaded" yet. it scrobbles at 70 percent... so if the whole video hasn't loaded yet (doesn't even have a length of video file), it will scrobble instantly because it thinks 100 percent has played.

Possible Solution: Ensure that the Addon doesn't scrobble unless at least one minute has played or that its 70 (or whatever is designated) percent of the usual episode length.

ekleop commented 6 years ago

yes, there is such problem. Will be fixed in the next release

daviddavo commented 6 years ago

Done, I'll upload it on the next commit

ekleop commented 6 years ago

Nice, I think after #30 we can make a push to the kodi's repo. After global testing of course

AzzieDev commented 4 years ago

Just wanted to say this issue is still persistent on occasion. Sometimes it might scrobble at the beginning or at 15 percent in, as the addon can't seem to get the episode length.

Perhaps if the addon pinged Simkl to determine the supposed episode length, it can avoid the issue of early false scrobbles. Can try to log this some time.