search

SINTEF-9012 / JArduino

Program your Arduino in Java
https://github.com/SINTEF-9012/JArduino/wiki
177 stars 63 forks source link

Changes for a Java Magazine paper #38

Closed romerorsp closed 8 years ago

romerorsp commented 9 years ago

Hi guys! I have these changes to add into the framework, if you allow me to contribute. Please let me know if I'm not in compliance with your workflow or if there are changes that you'd not enjoy to have.

These changes I've done in order to make the life easier for the Java developers that are going to read the paper I'm writing to the Brazilian Java Magazine. So, please, can I get involved and contribute?

Best Regards, Rômero Ricardo.

brice-morin commented 9 years ago

Hi,

Contributions are welcome, and we already accepted a few pull request like yours. I would however try to separate what is (J)Arduino specific (i.e. the commands that are in the Arduino API), from what is specific to your case study (not sure, but the ultrasonic stuff is probably not in the plain Arduino API). This second part should, IMHO, be part of your repository, whre you just extend the generic JArduino. Can you try to refactor your pull request in that way? Tell us if you need more info.