search

SINTEF-9012 / JArduino

Program your Arduino in Java
https://github.com/SINTEF-9012/JArduino/wiki
176 stars 63 forks source link

added javadoc style dcomentation to PWMPin #50

Closed lobsteroh closed 8 years ago

lobsteroh commented 8 years ago

everytime i run into situations where info takes time to find, i just add it to the page and request to pull to master. if you rather not have documentation comments, then shout.

lobsteroh commented 8 years ago

wasnt sure how to remove the merge remote tracking branch from my pull request, so i left it in. should not do any harm because it is already committed to master, right?

brice-morin commented 8 years ago

Javadoc is certainly very useful.

Support for Arduino Mega is also very useful. I am however not in favor of having all the pins of the Mega available by default (then we could write JArduino programs that manipulate non-existing pins of an Arduino Uno...)

We should probably have a "JArduinoUno" and a "JArduinoMega" so that depending on which we instantiate, we just have what we need.

lobsteroh commented 8 years ago

I see. That makes sense. If it were only a case of defining pins that don't exist for plugging anything into then that would probably be ok, but i just noticed that some pins that exist on both boards have different functional capabilities, like DigitalPin.Pin_4 is a PWMPin on mega but not on uno. I am not familiar with how you would want to see this done, so if you would be willing to do setup the class structure for the uno pin layout the way you like, then i will add the mega2560 accordingly.

On Wed, Mar 16, 2016, 14:30 Brice Morin notifications@github.com wrote:

Javadoc is certainly very useful.

Support for Arduino Mega is also very useful. I am however not in favor of having all the pins of the Mega available by default (then we could write JArduino programs that manipulate non-existing pins of an Arduino Uno...)

We should probably have a "JArduinoUno" and a "JArduinoMega" so that depending on which we instantiate, we just have what we need.

— You are receiving this because you modified the open/close state. Reply to this email directly or view it on GitHub https://github.com/SINTEF-9012/JArduino/pull/50#issuecomment-197474740