SplineModel: optionally enforce right-handedness and other improvements

SINTEF / Splipy

Spline modelling made easy.

GNU General Public License v3.0

100 stars 18 forks source link

Closed TheBB closed 3 years ago

TheBB commented 3 years ago

Enable with SplineModel(...., force_right_hand=True).

VikingScientist commented 3 years ago

This PR also needs to be able to enforce rational descriptions over the entire SplineModel

VikingScientist commented 3 years ago

Does the last commit fix issue #84 ?

TheBB commented 3 years ago

Oh, yep. That's exactly the problem I ran into.

VikingScientist commented 3 years ago

If you change the evaluation point in /utils/__init__.py:14 to the spline centerpoint, then we can merge this PR.

TheBB commented 3 years ago

Updated!

VikingScientist commented 3 years ago

Should I be worried about the failing test suite?

TheBB commented 3 years ago

I don't think so. It's been failing for a while on a particular combination of OS/Python version due to a bad opencv package.

For that matter, Travis is shit and I'm trying to move us to Github actions instead. #129

TheBB commented 3 years ago

Just wait a sec though.

TheBB commented 3 years ago

Should work now, lol. Missing paren. :-s