SINTEF / Splipy

Spline modelling made easy.
GNU General Public License v3.0
100 stars 18 forks source link

Force Numpy < 1.20 #148

Closed TheBB closed 3 years ago

TheBB commented 3 years ago

I found a problem.

Our wheels are built against 'the latest' Numpy version on any given platform. For most platforms, that's 1.20. Unfortunately, it seems Numpy 1.20 and 1.19 are binary incompatible, so when our wheel is installed alongside Numpy 1.19 we get an error, as seen here.

I believe the simplest solution for now is to add a version condition on Numpy that excludes 1.20, both when building the wheel and when installing the package.

When we drop support for Python 3.6 (perhaps end of this year, which is when it is end-of-life) we can upgrade the Numpy compatibility, since Numpy doesn't distribute wheels for 3.6 in the newer versions.