search

SINTEF / Splipy

Spline modelling made easy.
GNU General Public License v3.0
100 stars 18 forks source link

vector multiply bug in cylinder factory function #49

Closed prashnts closed 6 years ago

prashnts commented 6 years ago

Hey there,

In cylinder factory, a disk is extruded along an axis as seen here [1]. However, this scaler-to-tuple multiplication is incorrect and hence raises an error for other values of h. Instead it should be (h * i for i in axis) (or something equivalent).

[1] https://github.com/sintefmath/Splipy/blob/master/splipy/volume_factory.py#L140

VikingScientist commented 6 years ago

You are indeed right. Thanks for spotting this.